Wireshark-commits: [Wireshark-commits] master c621a77: PCP: updated protocol dissection for new PDU
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Feb 2015 16:57:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c621a7719757939a0b09f4be5ed9158e719c0c8f
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c621a77 by Ryan Doyle (ryan@xxxxxxxxxxxx):

    PCP: updated protocol dissection for new PDU types
    
    Introduce basic dissection for AUTH PDU type as well as detecting if a
    conversation is about to initiate a secure sockets connection (kind of
    like STARTTLS) and then pass all packets through the SSL dissector
    if that is the case. Also clean up some duplication with constants.
    
    Change-Id: I66f663ca6ab4291f8d0321430e3e126a0be77a93
    Reviewed-on: https://code.wireshark.org/review/7109
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  a355daf   Give users a more helpful error message if they enter an SSL protocol we don't know.
    adds  c621a77   PCP: updated protocol dissection for new PDU types


Summary of changes:
 epan/dissectors/packet-pcp.c |  402 +++++++++++++++++++++++++++++-------------
 1 file changed, 278 insertions(+), 124 deletions(-)