Wireshark-commits: [Wireshark-commits] master febc2e1: Fix a portability problem raised by Guy Harr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Feb 2015 18:52:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=febc2e145359c8ebe2e0c1d5a02fa972c5e54d5d
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

febc2e1 by Richard Sharpe (realrichardsharpe@xxxxxxxxx):

    Fix a portability problem raised by Guy Harris. My first implementation would
    not work on 32-bit platforms because I assumed that pointers were 64-bit
    items. I have now moved to a slightly different scheme suggested by Evan Huus.
    
    Change-Id: I34f4dceea9952d5633603e71a8e8ae8f4b9154cc
    Signed-of-by: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/7179
    Petri-Dish: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    

Actions performed:

    from  6331755   Get rid of duplicate typedef.
    adds  febc2e1   Fix a portability problem raised by Guy Harris. My first implementation would not work on 32-bit platforms because I assumed that pointers were 64-bit items. I have now moved to a slightly different scheme suggested by Evan Huus.


Summary of changes:
 epan/dissectors/packet-rsvd.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)