Wireshark-commits: [Wireshark-commits] master b5a3b65: Qt: Fix side effects of recent WiresharkDial
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Feb 2015 00:20:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5a3b65f7aefa7af82f6d4927de91f151d209b3c
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b5a3b65 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix side effects of recent WiresharkDialog changes.
    
    Quit the application when the main window closes. This cleans up any
    other top-level windows that might be open.
    
    Don't dereference a NULL pointer when opening the sequence dialog from
    the VoIP calls dialog.
    
    Change-Id: I9902d40ead1c5f2e541b6d79f3d957228e4e9687
    Reviewed-on: https://code.wireshark.org/review/7107
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  f85d1c8   WSUG: Add a note about dialogs vs windows.
    adds  b5a3b65   Qt: Fix side effects of recent WiresharkDialog changes.


Summary of changes:
 ui/qt/main_window.cpp       |    2 ++
 ui/qt/voip_calls_dialog.cpp |    5 +++--
 ui/qt/voip_calls_dialog.h   |    1 +
 ui/qt/wireshark_dialog.cpp  |    2 +-
 ui/qt/wireshark_dialog.h    |    1 -
 5 files changed, 7 insertions(+), 4 deletions(-)