Wireshark-commits: [Wireshark-commits] master-1.12 f651c8d: Do not iterate over reported length whe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Feb 2015 14:57:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f651c8d60e71f879719ce0fe1d511753a373ebc2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f651c8d by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Do not iterate over reported length when using tvb_find_line_end
    
    if captured length < reported length, this will trigger an infinite loop
    
    Change-Id: I1e4dac08ef827851da3a6d410133cb0e7bab2738
    Reviewed-on: https://code.wireshark.org/review/7056
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  268fd52   FTAM: get rid of an evil global variable
    adds  f651c8d   Do not iterate over reported length when using tvb_find_line_end


Summary of changes:
 epan/dissectors/packet-catapult-dct2000.c |    2 +-
 epan/dissectors/packet-http.c             |    4 ++--
 epan/dissectors/packet-irc.c              |    2 +-
 epan/dissectors/packet-l1-events.c        |    2 +-
 epan/dissectors/packet-ldss.c             |    2 +-
 epan/dissectors/packet-memcache.c         |    6 +++---
 epan/dissectors/packet-msrp.c             |    2 +-
 epan/dissectors/packet-rtsp.c             |    2 +-
 epan/dissectors/packet-sdp.c              |    4 ++--
 epan/dissectors/packet-sip.c              |    2 +-
 epan/dissectors/packet-sipfrag.c          |    2 +-
 epan/dissectors/packet-text-media.c       |    2 +-
 12 files changed, 16 insertions(+), 16 deletions(-)