Wireshark-commits: [Wireshark-commits] master 7369c25: IMAP: do not iterate over reported length wh
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Feb 2015 13:25:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7369c25ad41ef075688420f53f353e8e6c4ddfdb
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7369c25 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    IMAP: do not iterate over reported length when using tvb_find_line_end
    
    This function can only search in captured length buffer
    This fixes an ASAN failure reported by Alexis
    
    Change-Id: Ib936f918e057423d63ff34a5fc79fed602e56dfc
    Reviewed-on: https://code.wireshark.org/review/7052
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  29be26c   FTAM: get rid of an evil global variable
    adds  7369c25   IMAP: do not iterate over reported length when using tvb_find_line_end


Summary of changes:
 epan/dissectors/packet-imap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)