Wireshark-commits: [Wireshark-commits] master 3222cd1: ssl-utils: use ALPN hint for improved spdy/h
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 9 Feb 2015 12:58:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3222cd1df6b0c8a43d959a7913fc3bf4b53e9422
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3222cd1 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: use ALPN hint for improved spdy/http2 recognition
    
    This patch improves detection of a SPDY/3.1 in SSL capture. While at it,
    add other protocols from the RFC/drafts.
    
    spdy was tested against a private capture from spdy/3.1 communication
    between Chromium 40 and ssl.gstatic.com.
    http2 was tested against http2-16-ssl.pcapng from
    http://wiki.wireshark.org/SampleCaptures#SSL_with_decryption_keys
    
    Change-Id: I111efae34d614b7d8e37eaaa686b391d332753dd
    Reviewed-on: https://code.wireshark.org/review/7000
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  702618f   Fix use-after free in RTP player
    adds  3222cd1   ssl-utils: use ALPN hint for improved spdy/http2 recognition


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   58 ++++++++++++++++++++++++++++++++++--
 1 file changed, 56 insertions(+), 2 deletions(-)