Wireshark-commits: [Wireshark-commits] master 14c37af: dwarf: fix bug found by MSVC2013 Code Analys
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 8 Feb 2015 03:52:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14c37afb5d3bc96467528f6e9d710f131f451b03
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

14c37af by Bill Meier (wmeier@xxxxxxxxxxx):

    dwarf: fix bug found by MSVC2013 Code Analysis
    
    The following doesn't quite do what it might seem to be doing:
    
    *value |= (byte & 0x7F) << shift;  //guint64 *value // guint8 byte
    
    The warning from MSVC2013:
     Arithmetic overflow:  32-bit value is shifted, then cast to 64-bit
     value. Results might not be an expected value
    
    Change-Id: I06e196559ec0e84da77d8866355ae7f86ba43f73
    Reviewed-on: https://code.wireshark.org/review/7020
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  f494abd   qnet6: don't calculate crc if length is negative
    adds  14c37af   dwarf: fix bug found by MSVC2013 Code Analysis


Summary of changes:
 epan/dwarf.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)