Wireshark-commits: [Wireshark-commits] master 2c65b33: Fix RTP crash on RTP analysis attempt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Feb 2015 02:16:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c65b33b2169a1a40766d55f8eb6339e7b412794
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2c65b33 by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix RTP crash on RTP analysis attempt
    
    The tap listener was handling rtpstream_tapinfo_t* types while other
    users was expecting a GList* instead. Fix this and avoid future
    confusion by replacing void* pointers.
    
    Ping-Bug: 10714
    Change-Id: I66f62eaaed4a529714264bbf4e7ad1e72b46ce5a
    Reviewed-on: https://code.wireshark.org/review/6997
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  6f22eb6   Qt: Fix coloring rules reordering.
    adds  2c65b33   Fix RTP crash on RTP analysis attempt


Summary of changes:
 ui/gtk/rtp_stream_dlg.c     |   24 ++++++++++++------------
 ui/qt/rtp_stream_dialog.cpp |    4 +---
 ui/qt/rtp_stream_dialog.h   |    2 +-
 ui/rtp_stream.c             |    2 +-
 ui/rtp_stream.h             |    3 ++-
 5 files changed, 17 insertions(+), 18 deletions(-)