Wireshark-commits: [Wireshark-commits] master-1.12 187e028: rtmpt: Remove 'if (tree)'
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Jan 2015 04:14:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=187e028eb0daf6c0c9d2836cf64dda3ac414f794
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

187e028 by Bill Meier (wmeier@xxxxxxxxxxx):

    rtmpt: Remove 'if (tree)'
    
    Setting a var under 'if (tree)' and then using it later (not under 'if (tree)') to affect col_...()/expert_...() is not OK.
    
    Change-Id: I144b5fa50b4550cd14c604970f5d84dbf13f3e90
    Reviewed-on: https://code.wireshark.org/review/6799
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    (cherry picked from commit 717b5a2ecf15b7e7ad3483fa9d8c64336f8456a5)
    Reviewed-on: https://code.wireshark.org/review/6805
    

Actions performed:

    from  e00fd25   pana, gsm_abis_oml, rsl, netrom: Remove 'if (tree)'
    adds  187e028   rtmpt: Remove 'if (tree)'


Summary of changes:
 epan/dissectors/packet-rtmpt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)