Wireshark-commits: [Wireshark-commits] master-1.12 f269ffe: Lua can free tvbuffs too early
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Jan 2015 16:19:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f269ffedeb8e457b85cc20ac39ee82f86c22f575
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f269ffe by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Lua can free tvbuffs too early
    
    Lua-created tvbuffs should be kept around for the duration of pinfo's
    lifetime, instead of only for the duration of frame dissection. So
    instead of using the frame dissector's frame_end_routine, we'll register
    a callback to wmem for pinfo pool's allocator.
    
    Ping-Bug: 10888
    Change-Id: I3e9db671c3f2a7cab9e258aca17f3be8acaf2417
    Reviewed-on: https://code.wireshark.org/review/6768
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    (cherry picked from commit aec1bcf9a14116763f6fd4438173c5a953df7d18)
    Reviewed-on: https://code.wireshark.org/review/6790
    

Actions performed:

    from  635506b   gsm-rlcmac: use wmem_new0 for a struct
    adds  f269ffe   Lua can free tvbuffs too early


Summary of changes:
 doc/README.wmem          |    2 +-
 epan/wmem/wmem_user_cb.h |    2 +-
 epan/wslua/init_wslua.c  |   11 ++++++++---
 3 files changed, 10 insertions(+), 5 deletions(-)