Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 635506b: gsm-rlcmac: use wmem_new0 for a struct

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=635506bd4897873b7a6510cfe13f204023cf8b3f
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

635506b by Evan Huus (eapache@xxxxxxxxx):

    gsm-rlcmac: use wmem_new0 for a struct
    
    Fixes "Conditional jump or move depends on uninitialised value" from Valgrind.
    
    I couldn't really figure out how this code was supposed to function, it seems to
    initialize one member of the union and then expect *all* the others to just
    magically work (which they apparently do in most cases, oddly). The real bug
    could be in csnStreamDissector or who knows, but this at least turns "garbage
    data" into "zeros" which makes valgrind happy and turns a potential vuln into
    at worst a bad decoding.
    
    Bug: 10891
    Change-Id: Ia29dd625b46b3b76ff521b4203148fe8b0c59ec3
    Reviewed-on: https://code.wireshark.org/review/6769
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit d50b27f4ce310377c7a04d15aebac7d445c075f0)
    Reviewed-on: https://code.wireshark.org/review/6795
    

Actions performed:

    from  101c1f2   applemidi: col_...() shouldn't be called under 'if(tree)'
    adds  635506b   gsm-rlcmac: use wmem_new0 for a struct


Summary of changes:
 epan/dissectors/packet-gsm_rlcmac.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)