Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 fcc7db9: smb-pipe: prevent possible crash; gmtime() can return NULL.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fcc7db9b37e8b627cd876c23432be60f965f20dc
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

fcc7db9 by Bill Meier (wmeier@xxxxxxxxxxx):

    smb-pipe: prevent possible crash; gmtime() can return NULL.
    
    For FT_ABSOLUTE_TIME fields:
    
    Instead of calling gmtime()/mktime() to convert a time to UTC time
    which is then displayed using proto_tree_add_time(),
    
    Use ABSOLUTE_TIME_UTC as the 'display' value for the field and then
    display the field using proto_tree_add_item().
    
    Change-Id: I1926c40de76a86072437902cb7621d3873827b11
    Reviewed-on: https://code.wireshark.org/review/6659
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    (cherry picked from commit d1cace99e57643a8f836803b2bc9cac50e42ac98)
    Reviewed-on: https://code.wireshark.org/review/6664
    

Actions performed:

    from  c1312d3   BGP: EVPN - Route Type 4 - "Invalid length of IP Address" - "Expert Info" shows a false error
    adds  fcc7db9   smb-pipe: prevent possible crash; gmtime() can return NULL.


Summary of changes:
 epan/dissectors/packet-smb-pipe.c |   26 ++++++++------------------
 1 file changed, 8 insertions(+), 18 deletions(-)