Wireshark-commits: [Wireshark-commits] master 7a81add: synphasor: prevent possible crash; gmtime()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2015 20:50:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a81add848378117b5dd7759f83c2c3c72befaa7
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7a81add by Bill Meier (wmeier@xxxxxxxxxxx):

    synphasor: prevent possible crash; gmtime() can return NULL;
    
    Don't do manual conversion of a time-field to UTC using gmtime().
    Use the standard Wireshark mechanisms.
    
    Change-Id: I2eaee074a590ecab492336bb6ad794bdd036f699
    Reviewed-on: https://code.wireshark.org/review/6661
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  7e1d73d   dmp, gmhdr, vssmonitoring: prevent possible crashes;
    adds  7a81add   synphasor: prevent possible crash; gmtime() can return NULL;


Summary of changes:
 epan/dissectors/packet-synphasor.c |   14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)