Wireshark-commits: [Wireshark-commits] master-1.12 b48ec0b: smpp: Prevent crash if invalid date/tim
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2015 02:08:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b48ec0b3e9032587506b445aa81db728021916ed
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

b48ec0b by Bill Meier (wmeier@xxxxxxxxxxx):

    smpp: Prevent crash if invalid date/time field.
    
      gmtime()/localtime() can return NULL;
    
    Bug 10868
    Change-Id: I496bab62555c7741b3d159726e74a3d14c4b51cb
    Reviewed-on: https://code.wireshark.org/review/6644
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/6646
    

Actions performed:

    from  539b6b4   [Automatic manuf, services and enterprise-numbers update for 2015-01-18]
    adds  b48ec0b   smpp: Prevent crash if invalid date/time field.


Summary of changes:
 epan/dissectors/packet-smpp.c |   23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)