Wireshark-commits: [Wireshark-commits] master e530c89: Replace se alloced memory in compare stat ta
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Jan 2015 00:37:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e530c899406d2212fb7cb8821d083fb4871ff718
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e530c89 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Replace se alloced memory in compare stat tap.
    
    Also replaced comments mentioning se_alloc memory with wmem_file_scope, since it's more accurate.
    
    It seems that many of the TShark stat taps may be leaking memory, because the hash tables created by the taps don't get a chance to be freed.  Somewhat academic since TShark exits shortly after displaying any stats, but a leak none the less.
    
    Change-Id: I8ceecbd00d65b3442dc02d720b39c2e15aa0c8a6
    Reviewed-on: https://code.wireshark.org/review/6557
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7d43836   QT: stats_tree plug-ins not added to statistics menu
    adds  e530c89   Replace se alloced memory in compare stat tap.


Summary of changes:
 epan/addr_resolv.h                 |    2 +-
 epan/dissectors/packet-dcom.c      |    2 +-
 epan/dissectors/packet-giop.c      |    6 +++---
 epan/dissectors/packet-rtp.h       |    6 +++---
 epan/dissectors/packet-ssl-utils.h |    2 +-
 epan/next_tvb.h                    |    2 +-
 epan/oids.h                        |    2 +-
 ui/cli/tap-comparestat.c           |   16 +++++++++++++---
 ui/gtk/compare_stat.c              |   15 ++++++++++++---
 9 files changed, 36 insertions(+), 17 deletions(-)