Wireshark-commits: [Wireshark-commits] master 9f5e4fb: uat_load() and uat_save() return a success i
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Jan 2015 21:01:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f5e4fb7a51741a286ce5bc92a6f335ed58587a2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9f5e4fb by Guy Harris (guy@xxxxxxxxxxxx):

    uat_load() and uat_save() return a success indication; use it.
    
    Instead of always ignoring the return value, always check it, and only
    report an error if it returns FALSE.
    
    (Alternative: have it return NULL on success and a pointer to a
    g_malloc()ed string on failure.)
    
    Fix a comment while we're at it.
    
    Change-Id: Icb72c9f47775b6552e3eb4fe5ddcc85482bfb5fb
    Reviewed-on: https://code.wireshark.org/review/6528
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  25f010b   MAC LTE: upgrade dissector to v12.4.0
    adds  9f5e4fb   uat_load() and uat_save() return a success indication; use it.


Summary of changes:
 caputils/airpcap_loader.c              |   12 ++++++------
 epan/uat.c                             |   13 ++++++-------
 ui/gtk/uat_gui.c                       |   17 ++++++-----------
 ui/qt/io_graph_dialog.cpp              |   12 ++++++++----
 ui/qt/sctp_chunk_statistics_dialog.cpp |    6 +++---
 ui/qt/uat_dialog.cpp                   |    7 ++-----
 6 files changed, 31 insertions(+), 36 deletions(-)