Wireshark-commits: [Wireshark-commits] master effc826: Add preference to display spaces between byt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Jan 2015 19:57:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=effc8266ce2a87c5987018511f9bb2f61c34ba57
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

effc826 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add preference to display spaces between bytes for FT_BYTES fields.
    
    I think this can make fields more readable (for a small amount of bytes).
    
    Converted DeviceNet dissector to use proto_tree_add_item for some FT_BYTES field as tvb_bytes_to_str_punct was used to create this effect "manually".
    
    Change-Id: I59e2acf9b00a4eb1279e6c2b2b7bd8ecef20db9b
    Reviewed-on: https://code.wireshark.org/review/6304
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  02fb290   Sort the value_string_exts at dissector registration time.
    adds  effc826   Add preference to display spaces between bytes for FT_BYTES fields.


Summary of changes:
 epan/dissectors/packet-devicenet.c |   18 ++++++------------
 epan/prefs.c                       |    6 ++++++
 epan/prefs.h                       |    1 +
 epan/proto.c                       |   19 +++++++++++++++++--
 4 files changed, 30 insertions(+), 14 deletions(-)