Wireshark-commits: [Wireshark-commits] master 51acf16: packet-mq: sort some value_string_ext in dis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Jan 2015 17:42:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51acf1685b3a982f0502f6540f9ab00f543e8270
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

51acf16 by Robert Grange (robionekenobi@xxxxxxxxxx):

    packet-mq: sort some value_string_ext in dissector
    
    Some value_string_ext are sorted only in the dissector,
    and only once.
    
    Adapted as said in comments.
    Added test for sort in dissect_mq_spx
    
    Change-Id: If72159fe96ab28a3ed540778d67996e152b4f110
    Reviewed-on: https://code.wireshark.org/review/6444
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  b760da9   MQ: ensure that at least 4 bytes were captured before doing heuristic checks
    adds  51acf16   packet-mq: sort some value_string_ext in dissector


Summary of changes:
 epan/dissectors/packet-mq.c |   92 +++++++++++++++++++++++++------------------
 1 file changed, 54 insertions(+), 38 deletions(-)