Wireshark-commits: [Wireshark-commits] master-1.12 1d19433: IS-IS: Incorrect decoding of IPv4 Inter
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Jan 2015 14:02:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d19433854aa0f92cf3a8a4b64f634181ebfd938
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

1d19433 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    IS-IS: Incorrect decoding of IPv4 Interface/Neighbor Address sub-TLVs in Extended IS Reachability TLV
    
    Correct 4-byte IPv4 address is incorrectly detected as wrong 6-byte IPv4 address and cannot be decoded (IPv4 Interface Address (sub-TLV type 6) and IPv4 Neighbor Address (sub-TLV type 8) of Extended IS Reachability TLV (TLV type 22) of IS-IS.
    
    Wrong offset for some Sub-TLV
    
    Issue found by Alexander Okonnikov
    
    Bug: 10837
    Reviewed-on: https://code.wireshark.org/review/6453
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Signed-off-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    
    Conflicts:
    	epan/dissectors/packet-isis-lsp.c
    Change-Id: I81d083722da72115e1905237352650d380e9d0ac
    Reviewed-on: https://code.wireshark.org/review/6467
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  05cd2fc   To register an SCTP port, register in "sctp.port", not "udp.port".
    adds  1d19433   IS-IS: Incorrect decoding of IPv4 Interface/Neighbor Address sub-TLVs in Extended IS Reachability TLV


Summary of changes:
 epan/dissectors/packet-isis-lsp.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)