Wireshark-commits: [Wireshark-commits] master 456095c: disperse atalk-utils.[ch]
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 9 Jan 2015 05:59:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=456095c89dd5fe257ce86d5529179295ebf9151e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

456095c by Michael Mann (mmann78@xxxxxxxxxxxx):

    disperse atalk-utils.[ch]
    
    The functionality was suiting for address_to_str.c and the #defines belong in packet-atalk.h.  Kept the address structure with the "address string conversion", but that can probably be better cleaned up when the address to str as a whole is cleaned up.
    
    Would also consider making AT_ATALK an FT_ type as well.
    
    Change-Id: Ia534096c707e6fb94acdfee0d332beda6571c371
    Reviewed-on: https://code.wireshark.org/review/6417
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d296c75   Some more random removal of ep_ memory.
    adds  456095c   disperse atalk-utils.[ch]


Summary of changes:
 epan/CMakeLists.txt            |    1 -
 epan/Makefile.common           |    2 --
 epan/address_to_str.c          |   17 ++++++++++-
 epan/atalk-utils.c             |   53 ----------------------------------
 epan/atalk-utils.h             |   61 ----------------------------------------
 epan/column-utils.c            |    1 -
 epan/dissectors/packet-atalk.c |    2 +-
 epan/dissectors/packet-atalk.h |   12 ++++++++
 epan/dissectors/packet-eigrp.c |    2 +-
 epan/packet.c                  |    1 -
 epan/to_str.h                  |   15 ++++++++++
 11 files changed, 45 insertions(+), 122 deletions(-)
 delete mode 100644 epan/atalk-utils.c
 delete mode 100644 epan/atalk-utils.h