Wireshark-commits: [Wireshark-commits] master 67b1593: Remove proto_tree_add_ax25
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 9 Jan 2015 01:10:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67b15939219499248432e50a73f76fed5fb03c8c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

67b1593 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove proto_tree_add_ax25
    
    There isn't a legitimate use for the API, all cases can be covered with proto_tree_add_item.  As a bonus, a few more tvb_get_ptr calls can be removed.
    
    Change-Id: I3bb86ba8f05ef3363407bcfe9b059ee27ebc135d
    Reviewed-on: https://code.wireshark.org/review/6429
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ecaa1f8   convert variables that were static just because of SET_ADDRESS macro to use the proper pinfo->pool instead.
    adds  67b1593   Remove proto_tree_add_ax25


Summary of changes:
 doc/README.dissector            |    3 ---
 epan/dissectors/packet-ax25.c   |   16 +++++-----------
 epan/dissectors/packet-netrom.c |   20 ++++++--------------
 epan/proto.c                    |   19 -------------------
 epan/proto.h                    |   12 ------------
 5 files changed, 11 insertions(+), 59 deletions(-)