Wireshark-commits: [Wireshark-commits] master 734e408: MSVC: Fix opting out of libraries
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 7 Jan 2015 14:37:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=734e4083c9bd18a15451691ee5967f14a4c4019d
Submitter: Graham Bloice (graham.bloice@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

734e408 by Orgad Shaneh (orgads@xxxxxxxxx):

    MSVC: Fix opting out of libraries
    
    When *_DIR variables are defined (even if empty), nmake tries
    to build them and fails.
    
    Don't set them at all if not configured to.
    
    Change-Id: I3825c16f26e45a1a3fc489633084a074838f8c34
    Reviewed-on: https://code.wireshark.org/review/6365
    Petri-Dish: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    

Actions performed:

    from  ed9a9be   Use tvb_address_to_str as an optimization
    adds  734e408   MSVC: Fix opting out of libraries


Summary of changes:
 Makefile.nmake |    3 +++
 config.nmake   |   16 ----------------
 2 files changed, 3 insertions(+), 16 deletions(-)