Wireshark-commits: [Wireshark-commits] master 47d670d: Add tvb_address_to_str.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 7 Jan 2015 04:25:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=47d670d3d7d17df1e29a55d05413a2fd3d0f8e6a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

47d670d by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add tvb_address_to_str.
    
    This is intended to handle ALL address types retrieved from a tvbuff.
    
    One of the (good) side effects of this function is that it can replace a lot of the "hidden" ep_alloc calls used to allocate memory for the address string.
    
    A few existing "popular" helper tvb_ functions were turned into pure macros calling tvb_address_to_str.  Some of the "less used" helper tvb_ functions were just directly replaced with tvb_address_to_str.
    
    Change-Id: I361d991c4ad90142173e63eae02a94d68af3ec43
    Reviewed-on: https://code.wireshark.org/review/6333
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0f426d6   Improved handling of ARDP fragmented packets.
    adds  47d670d   Add tvb_address_to_str.


Summary of changes:
 debian/libwireshark0.symbols         |    8 +-
 epan/address_to_str.c                |  166 ++++++++++++++++++++--------------
 epan/dissectors/packet-eigrp.c       |    3 +-
 epan/dissectors/packet-icmpv6.c      |    6 +-
 epan/dissectors/packet-vines.c       |    4 +-
 epan/to_str.h                        |   39 ++++++--
 tools/convert_proto_tree_add_text.pl |    5 +-
 7 files changed, 139 insertions(+), 92 deletions(-)