Wireshark-commits: [Wireshark-commits] master b90f784: Add sanity check to ensure integer types don
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 2 Jan 2015 17:38:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b90f7846f4e289680eb6812d64329fa578ca7443
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b90f784 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add sanity check to ensure integer types don't get set to BASE_NONE.
    
    This is checked by Wireshark, but the script should catch it earlier in case Wireshark/TShark isn't run after the script is executed (a mistake I've made several times).
    
    Change-Id: I1d113871b10fcae5a6d3e9036cc80d7b1ec1ae57
    Reviewed-on: https://code.wireshark.org/review/6245
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e7d0cdc   Fix lua tests on Windows
    adds  b90f784   Add sanity check to ensure integer types don't get set to BASE_NONE.


Summary of changes:
 tools/convert_proto_tree_add_text.pl |   15 +++++++++++++++
 1 file changed, 15 insertions(+)