Wireshark-commits: [Wireshark-commits] master-1.12 e3c0c98: When deccoding base-64, the result is t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 2 Jan 2015 02:20:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3c0c98cf2846b3ef7c4636f0320d7af77737658
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

e3c0c98 by Guy Harris (guy@xxxxxxxxxxxx):

    When deccoding base-64, the result is the length of the *decoded* result.
    
    That way, for example, format_text() calls on the decoded result don't
    go past the end of the decoded result.
    
    Fix some more indentation while we're at it.
    
    Conflicts:
    	epan/dissectors/packet-smtp.c
    
    Bug: 10823
    Change-Id: Iff40c89a2e5734b7f6a21ea8b654cb0869aac774
    Reviewed-on: https://code.wireshark.org/review/6225
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  db22c94   Fix tpyo.
    adds  e3c0c98   When deccoding base-64, the result is the length of the *decoded* result.


Summary of changes:
 epan/dissectors/packet-smtp.c |  107 +++++++++++++++++++++++------------------
 1 file changed, 61 insertions(+), 46 deletions(-)