Wireshark-commits: [Wireshark-commits] master e8ec11f: Qt: Add a WiresharkDialog convenience class.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 29 Dec 2014 01:42:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8ec11fb7e67f83a7296f1e87451f3d7ddd5d85d
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e8ec11f by Gerald Combs (gerald@xxxxxxxx):

    Qt: Add a WiresharkDialog convenience class.
    
    Add WiresharkDialog, a common base class for dialogs centered around
    capture files. Make it a parent of Capture File Properties, Traffic
    Table, Conversations, and Endpoints.
    
    Rename CaptureFile::read_only_ to file_closed_. Add methods to
    WiresharkApplication for generating consistent window titles.
    
    Change-Id: Idc771556d8192e60f85dddc08fc4757698dee257
    Reviewed-on: https://code.wireshark.org/review/6097
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  c1d9d93   Restore string.h to os_version.c
    adds  e8ec11f   Qt: Add a WiresharkDialog convenience class.


Summary of changes:
 ui/qt/CMakeLists.txt                         |    2 +
 ui/qt/Makefile.common                        |    6 ++-
 ui/qt/Wireshark.pro                          |    4 +-
 ui/qt/capture_file.cpp                       |    7 ++-
 ui/qt/capture_file.h                         |    5 +-
 ui/qt/capture_file_properties_dialog.cpp     |   41 ++++++--------
 ui/qt/capture_file_properties_dialog.h       |   15 +++---
 ui/qt/capture_file_properties_dialog.ui      |    3 --
 ui/qt/conversation_dialog.cpp                |   10 ++--
 ui/qt/conversation_dialog.h                  |    2 +-
 ui/qt/endpoint_dialog.cpp                    |    2 +-
 ui/qt/endpoint_dialog.h                      |    2 +-
 ui/qt/main_window.cpp                        |    1 +
 ui/qt/main_window_slots.cpp                  |    8 ++-
 ui/qt/traffic_table_dialog.cpp               |   32 +++--------
 ui/qt/traffic_table_dialog.h                 |    9 ++--
 ui/qt/wireshark_application.cpp              |   18 +++++--
 ui/qt/wireshark_application.h                |    4 +-
 ui/qt/wireshark_dialog.cpp                   |   74 ++++++++++++++++++++++++++
 ui/qt/{elided_label.h => wireshark_dialog.h} |   43 +++++++++------
 20 files changed, 178 insertions(+), 110 deletions(-)
 create mode 100644 ui/qt/wireshark_dialog.cpp
 copy ui/qt/{elided_label.h => wireshark_dialog.h} (58%)