Wireshark-commits: [Wireshark-commits] master 51e5869: Get rid of packet data members of header str
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 27 Dec 2014 20:56:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51e58698d281bd45b5040551a3db63b4661be0af
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

51e5869 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of packet data members of header structures.
    
    Instead, have a special macro using the size of the header structure to
    find the offset of the packet data.
    
    This means that:
    
    	1) you don't have to throw "-{size of data member}" into the
    	   macros that calculate the sizes of the header structures;
    
    	2) you don't have a bunch of randomly-chosen data field sizes;
    
    	3) you don't have sizes of 0, which cause problems with
    	   compilers that don't support zero-length arrays;
    
    	4) you don't have some apparently-incorrect "-{size of data
    	   member}" values (if they're correct, please fix the structure
    	   definitions).
    
    Change-Id: Iea368b83fa2d184bd6df453d51756e4749714e2c
    Reviewed-on: https://code.wireshark.org/review/6082
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ea6f5a3   Zebra dissector highlights wrong byte for version and is missing some fields
    adds  51e5869   Get rid of packet data members of header structures.


Summary of changes:
 wiretap/netscaler.c |   69 +++++++++++++++++++--------------------------------
 1 file changed, 26 insertions(+), 43 deletions(-)