Wireshark-commits: [Wireshark-commits] master-1.12 cdc440a: Don't use a leading - in getopt_long()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 27 Dec 2014 02:49:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cdc440aeb7495979352306290490bb9997415423
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

cdc440a by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use a leading - in getopt_long() option strings.
    
    The behavior of a leading - is platform-dependent.  It also means that
    non-option arguments are treated in a fashion that we're not handling,
    so capture filters given as non-option arguments at the end of the
    command line don't work.  (The Linux getopt() man page says that a
    leading - "is used by programs that were written to expect options and
    other argv-elements in any order and that care about the ordering of the
    two."  We are not such a program.)
    
    Change-Id: Idab5db11980abf785096f64d510549bae9e7275b
    Based-On-A-Change-From: Peter Hatina <phatina@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/6072
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4ed34c5   Add an (empty) list of long options to tfshark.
    adds  cdc440a   Don't use a leading - in getopt_long() option strings.


Summary of changes:
 tfshark.c |   13 +++++++++----
 tshark.c  |   13 +++++++++----
 2 files changed, 18 insertions(+), 8 deletions(-)