Wireshark-commits: [Wireshark-commits] master 5cdad9f: Qt: Add methods to CaptureFile and Wireshark
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Dec 2014 18:12:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5cdad9fe423662e2aea3d63540cd19b7e518b7c3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5cdad9f by Gerald Combs (gerald@xxxxxxxx):

    Qt: Add methods to CaptureFile and WiresharkApplication.
    
    Add isValid, fileTitle, and retapPackets methods to CaptureFile. Add
    application name and title separator convenience methods to
    WiresharkApplication.
    
    Convert traffic tables, conversations, and endpoints to use CaptureFile
    directly and to let the user know when the capture file is closed. Set
    the file dialog titles while we're here.
    
    Change-Id: I990392786d3833e1e0b3638aa2d34a5ada39fa13
    Reviewed-on: https://code.wireshark.org/review/5957
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  30c3d39   Revert "Move packet-kerberos.c to the dirty dissectors because it generates warnings (at least on NetBSD), presumably due to our use of -Wc++-compat:"
    adds  5cdad9f   Qt: Add methods to CaptureFile and WiresharkApplication.


Summary of changes:
 ui/qt/capture_file.cpp          |   30 +++++++++++++++++++++---
 ui/qt/capture_file.h            |   20 ++++++++++++++++
 ui/qt/conversation_dialog.cpp   |   48 +++++++++++++++++++--------------------
 ui/qt/conversation_dialog.h     |    4 ++--
 ui/qt/endpoint_dialog.cpp       |   30 ++++++++++++------------
 ui/qt/endpoint_dialog.h         |    4 ++--
 ui/qt/main_window_slots.cpp     |    8 ++-----
 ui/qt/traffic_table_dialog.cpp  |   38 ++++++++++++++++++++++---------
 ui/qt/traffic_table_dialog.h    |   10 +++++---
 ui/qt/wireshark_application.cpp |    7 ++++++
 ui/qt/wireshark_application.h   |   25 +++++---------------
 11 files changed, 137 insertions(+), 87 deletions(-)