Wireshark-commits: [Wireshark-commits] master 37940ee: Fix AARP AppleTalk address parsing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Dec 2014 06:57:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37940ee5adb8b7bc42e013fe14457871e434ac70
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

37940ee by Doug Brown (doug@xxxxxxxxxxxxxxxxxxxxx):

    Fix AARP AppleTalk address parsing
    
    AppleTalk addresses are 3 bytes long and stored in AARP packets as 4 bytes.
    The high byte should be 0, followed by 2-byte network number, followed by
    1-byte node number.
    
    The previous code was assuming that the high two bytes were the network number,
    followed by the 1-byte node number, followed by 0.
    
    Change-Id: I467ec6edac353796db0b96fbac65658d5c5491d3
    Reviewed-on: https://code.wireshark.org/review/5968
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7b721a1   Squelch a compiler warning.
    adds  37940ee   Fix AARP AppleTalk address parsing


Summary of changes:
 epan/dissectors/packet-aarp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)