Wireshark-commits: [Wireshark-commits] master b5d7b7a: Cleanup use of #includes in non-generated ep
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Dec 2014 05:46:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5d7b7ab6e6b0e595d3250d7fa6553d0da79c000 Submitter: Bill Meier (wmeier@xxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: b5d7b7a by Bill Meier (wmeier@xxxxxxxxxxx): Cleanup use of #includes in non-generated epan/dissector/*.c Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx> Actions performed: from 14cff7b Qt: Don't clear the capture file properties. adds b5d7b7a Cleanup use of #includes in non-generated epan/dissector/*.c Summary of changes: epan/dissectors/file-elf.c | 2 -- epan/dissectors/file-file.c | 7 ++---- epan/dissectors/file-gif.c | 2 -- epan/dissectors/file-jpeg.c | 2 -- epan/dissectors/file-mp4.c | 4 ++-- epan/dissectors/file-png.c | 2 -- epan/dissectors/packet-3com-njack.c | 2 -- epan/dissectors/packet-3com-xns.c | 1 - epan/dissectors/packet-3g-a11.c | 3 --- epan/dissectors/packet-6lowpan.c | 2 -- epan/dissectors/packet-9p.c | 4 ---- epan/dissectors/packet-a21.c | 1 - epan/dissectors/packet-aarp.c | 1 - epan/dissectors/packet-aastra-aasp.c | 2 -- epan/dissectors/packet-acap.c | 1 - epan/dissectors/packet-acn.c | 2 -- epan/dissectors/packet-acr122.c | 2 -- epan/dissectors/packet-actrace.c | 2 -- epan/dissectors/packet-adb.c | 1 - epan/dissectors/packet-adb_cs.c | 1 - epan/dissectors/packet-adb_service.c | 1 - epan/dissectors/packet-adwin-config.c | 4 +--- epan/dissectors/packet-adwin.c | 3 --- epan/dissectors/packet-afp.c | 2 -- epan/dissectors/packet-afs.c | 3 --- epan/dissectors/packet-agentx.c | 2 +- epan/dissectors/packet-aim-admin.c | 2 -- epan/dissectors/packet-aim-adverts.c | 2 -- epan/dissectors/packet-aim-bos.c | 2 -- epan/dissectors/packet-aim-buddylist.c | 2 -- epan/dissectors/packet-aim-chat.c | 4 ---- epan/dissectors/packet-aim-chatnav.c | 2 -- epan/dissectors/packet-aim-directory.c | 2 -- epan/dissectors/packet-aim-email.c | 2 -- epan/dissectors/packet-aim-generic.c | 2 -- epan/dissectors/packet-aim-icq.c | 2 -- epan/dissectors/packet-aim-invitation.c | 2 -- epan/dissectors/packet-aim-location.c | 2 -- epan/dissectors/packet-aim-messaging.c | 2 -- epan/dissectors/packet-aim-oft.c | 2 -- epan/dissectors/packet-aim-popup.c | 2 -- epan/dissectors/packet-aim-signon.c | 2 -- epan/dissectors/packet-aim-ssi.c | 2 -- epan/dissectors/packet-aim-sst.c | 2 -- epan/dissectors/packet-aim-stats.c | 2 -- epan/dissectors/packet-aim-translate.c | 2 -- epan/dissectors/packet-aim-userlookup.c | 2 -- epan/dissectors/packet-aim.c | 2 -- epan/dissectors/packet-ajp13.c | 3 --- epan/dissectors/packet-alcap.c | 11 ++++----- epan/dissectors/packet-alljoyn.c | 2 -- epan/dissectors/packet-amqp.c | 2 -- epan/dissectors/packet-amr.c | 2 -- epan/dissectors/packet-ancp.c | 3 +-- epan/dissectors/packet-ans.c | 4 +--- epan/dissectors/packet-ansi_637.c | 2 -- epan/dissectors/packet-ansi_801.c | 2 -- epan/dissectors/packet-ansi_a.c | 2 -- epan/dissectors/packet-aodv.c | 2 -- epan/dissectors/packet-aoe.c | 5 +---- epan/dissectors/packet-aol.c | 2 -- epan/dissectors/packet-ap1394.c | 1 - epan/dissectors/packet-app-pkix-cert.c | 4 +--- epan/dissectors/packet-applemidi.c | 2 -- epan/dissectors/packet-aprs.c | 4 ---- epan/dissectors/packet-ar_drone.c | 2 -- epan/dissectors/packet-arcnet.c | 2 -- epan/dissectors/packet-armagetronad.c | 4 ---- epan/dissectors/packet-arp.c | 2 -- epan/dissectors/packet-artnet.c | 4 +--- epan/dissectors/packet-aruba-adp.c | 1 - epan/dissectors/packet-aruba-erm.c | 1 - epan/dissectors/packet-aruba-iap.c | 1 - epan/dissectors/packet-aruba-papi.c | 2 -- epan/dissectors/packet-ascend.c | 2 -- epan/dissectors/packet-asf.c | 1 - epan/dissectors/packet-assa_r3.c | 4 +--- epan/dissectors/packet-asterix.c | 6 ++--- epan/dissectors/packet-at.c | 1 - epan/dissectors/packet-atalk.c | 8 ++----- epan/dissectors/packet-atm.c | 1 - epan/dissectors/packet-atmtcp.c | 2 -- epan/dissectors/packet-auto_rp.c | 1 - epan/dissectors/packet-ax25-kiss.c | 4 ---- epan/dissectors/packet-ax25-nol3.c | 3 --- epan/dissectors/packet-ax25.c | 6 +---- epan/dissectors/packet-ax4000.c | 4 +--- epan/dissectors/packet-ayiya.c | 1 - epan/dissectors/packet-babel.c | 4 ---- epan/dissectors/packet-bacapp.c | 3 --- epan/dissectors/packet-bacnet.c | 2 -- epan/dissectors/packet-banana.c | 2 -- epan/dissectors/packet-bat.c | 2 -- epan/dissectors/packet-batadv.c | 1 - epan/dissectors/packet-bctp.c | 1 - ... 884 lines suppressed ...
- Prev by Date: [Wireshark-commits] master 14cff7b: Qt: Don't clear the capture file properties.
- Next by Date: [Wireshark-commits] master ce211a4: Cleanup use of #includes in a few recently committed dissectors.
- Previous by thread: [Wireshark-commits] master 14cff7b: Qt: Don't clear the capture file properties.
- Next by thread: [Wireshark-commits] master ce211a4: Cleanup use of #includes in a few recently committed dissectors.
- Index(es):