Wireshark-commits: [Wireshark-commits] master cadf1a5: Remove profinet_type from packet_info struct
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Dec 2014 01:57:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cadf1a5fce380f1e726717f3d47a794b5250caf9
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cadf1a5 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove profinet_type from packet_info structure.
    
    Profinet I/O and DCOM CBA had completely separate uses for the profinet_type member, so it's okay to separate them with different proto ids tracking the proto_data.
    
    Change-Id: I7b9c01b8d4f74d51fe9f9ef2f957479dff0a7157
    Reviewed-on: https://code.wireshark.org/review/5852
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d7fd00d   MIPv6: simplify fixed point degrees conversion
    adds  cadf1a5   Remove profinet_type from packet_info structure.


Summary of changes:
 epan/packet_info.h                      |    1 -
 plugins/profinet/packet-dcerpc-pn-io.c  |   12 ++++--
 plugins/profinet/packet-dcom-cba-acco.c |   66 ++++++++++++++++---------------
 3 files changed, 43 insertions(+), 36 deletions(-)