Wireshark-commits: [Wireshark-commits] master 2bb8255: Consolidate RTP stream structs.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Dec 2014 16:49:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2bb8255e29e26c7c14f7a83ce33b41f9af18501e
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2bb8255 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Consolidate RTP stream structs.
    
    Consolidate the three different RTP stream structs in ui/rtp_stream.h,
    ui/gtk/rtp_player.c, and ui/voip_calls.c into one. Make the member names
    a bit more consistent. Document what each GList contains. Use nstime_t
    for timestamps since that's what we get from the frame data. Use g_new0
    to initialize our structs.
    
    Change-Id: I2b3f8f2051394a6a98a5c7bc49c117f07161d031
    Reviewed-on: https://code.wireshark.org/review/5843
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  79b5bb4   Fix typo.
    adds  2bb8255   Consolidate RTP stream structs.


Summary of changes:
 ui/cli/tap-rtp.c        |   12 ++--
 ui/gtk/rtp_player.c     |  171 +++++++++++++++++++----------------------------
 ui/gtk/rtp_stream_dlg.c |   16 ++---
 ui/rtp_stream.h         |   32 +++++----
 ui/tap-rtp-common.c     |   97 ++++++++++-----------------
 ui/voip_calls.c         |   85 +++++++++--------------
 ui/voip_calls.h         |    2 +-
 7 files changed, 169 insertions(+), 246 deletions(-)