Wireshark-commits: [Wireshark-commits] master 4d3c7b5: Don't bother with __builtin_floorl().
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Dec 2014 05:09:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d3c7b50deeaef8a1b54320ed78b2a523d130d76
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4d3c7b5 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't bother with __builtin_floorl().
    
    At least as I read the GCC documentation, if GCC supports a builtin
    floorl() at all, it will always treat floorl() and
    __builtin_floorl() the same (it's reserved in C90 and defined in C99, so
    nobody should ever write C code assuming floorl() won't be treated in
    that afshion).
    
    In addition, the GCC 3.3.6 manual says nothing about __builtin_floorl(),
    so it probably won't help to use it.  If it appears to help, there's
    probably something else going on.
    
    Also, GCC appears not to like "#ifdef (__GNUC__)", as the parentheses
    mean it's testing an expression, not a macro name.
    
    Change-Id: Ib88b52c366d7f3b1637bb408fb18d04b67c27e4b
    Reviewed-on: https://code.wireshark.org/review/5909
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  caf4cc6   Use AC_SEARCH_LIBS() for math functions.
    adds  4d3c7b5   Don't bother with __builtin_floorl().


Summary of changes:
 wsutil/floorl.c |   11 -----------
 1 file changed, 11 deletions(-)