Wireshark-commits: [Wireshark-commits] master 2f44afe: Use ENCTYPE_NULL in the krb5_crypto_init() c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Dec 2014 01:57:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f44afef8017f8c3b85818488236b28702f56324
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2f44afe by Guy Harris (guy@xxxxxxxxxxxx):

    Use ENCTYPE_NULL in the krb5_crypto_init() call.
    
    That appears to be a name supplied both by MIT and Heimdal Kerberos.
    Using it makes it a bit clearer what the code is doing, and might avoid
    type clash warnings if it's the right type (e.g., if it's a member of an
    enum, as it is in Heimdal, and the corresponding argument to
    krb5_crypto_init() is of the same type, the types will match).
    
    Change-Id: I81b79223f789b8d1ec47180b7636ac1d83e03681
    Reviewed-on: https://code.wireshark.org/review/5898
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2376953   Another missing change
    adds  2f44afe   Use ENCTYPE_NULL in the krb5_crypto_init() call.


Summary of changes:
 asn1/kerberos/packet-kerberos-template.c |    2 +-
 epan/dissectors/packet-kerberos.c        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)