Wireshark-commits: [Wireshark-commits] master 625ba02: Clean up handling of files without a known e
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Dec 2014 05:36:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=625ba02b69c4254af20d63cfc274afd2f262639a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

625ba02 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up handling of files without a known encapsulation.
    
    Fail with an "unsupported encapsulation" error for MTP2 and SSCOP,
    rather than just returning "unknown encapsulation", and fail with that
    if the encapsulation isn't filled in as well, although that might be a
    deeper problem.
    
    (Not that people should be handing text output files from K12 analyzers
    anyway - they should hand us RF5 files and, if we can't handle their
    file, file a bug and give us the file so we can further reverse-engineer
    the format.)
    
    Change-Id: I6bbd5f81787d69bd3b41eaedf2893d179f11ad6a
    Reviewed-on: https://code.wireshark.org/review/5792
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ad299df   HiSLIP: disable heuristic dissector by default
    adds  625ba02   Clean up handling of files without a known encapsulation.


Summary of changes:
 wiretap/k12text.l |   40 ++++++++++++++++++++++++----------------
 1 file changed, 24 insertions(+), 16 deletions(-)