Wireshark · Wireshark-commits: [Wireshark-commits] master 6ee78f3: http: properly calculate end of chunked response

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ee78f3be167807b9e2790b8f88f14ea1a4c9462
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6ee78f3 by Peter Wu (peter@xxxxxxxxxxxxx):

    http: properly calculate end of chunked response
    
    It was previously assumed that the remainder of a packet contains a
    chunked-body response. This does not have be the case, and if the
    assumption is violated, then the dissector would add multiple parts to a
    single "De-chunked entity body".
    
    This patch properly calculates the end of a chunked-body response,
    taking the optional trailer-part into account and adjusting the size of
    the chunked-body data as needed.
    
    The CRLF in last-chunk that was previously dissected as "Chunk Boundary"
    is the last CRLF that closes chunked-body, it is not part of last-chunk
    (as it has no chunk-data to terminate).
    
    A new header field is added for this trailer-part (RFC 7230 sec. 4.1).
    
    Bug: 10707
    Change-Id: Ifef1cc7dd0443edca4198eb1c27f58719f85fa9f
    Reviewed-on: https://code.wireshark.org/review/5526
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  db93414   RDM: Mode verbose decoding of parameter IDs.     -> I don't see why they were uint8; ANSI E1.33 and ANSI E1.20 use uint16
    adds  6ee78f3   http: properly calculate end of chunked response


Summary of changes:
 epan/dissectors/packet-http.c |  102 ++++++++++++++++++++++++++++-------------
 1 file changed, 71 insertions(+), 31 deletions(-)