Wireshark-commits: [Wireshark-commits] master-1.12 c9a6d31: RDM: Mode verbose decoding of parameter
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Dec 2014 15:05:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9a6d31bf3c64166a8d293d8dd925a6923a949a0
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

c9a6d31 by zeuz (czingerl@xxxxxxxxx):

    RDM: Mode verbose decoding of parameter IDs.
        -> I don't see why they were uint8; ANSI E1.33 and ANSI E1.20 use uint16
    
    Change-Id: Ia2c024b503d6a4b8c18020699bdc676a8459dcbd
    Reviewed-on: https://code.wireshark.org/review/5783
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit db93414049b3094734e33a0da49f611c2a211410)
    Reviewed-on: https://code.wireshark.org/review/5784
    

Actions performed:

    from  1416248   Don't assert out on tvb_memcpy() with a null data pointer if the length is 0.
    adds  c9a6d31   RDM: Mode verbose decoding of parameter IDs.     -> I don't see why they were uint8; ANSI E1.33 and ANSI E1.20 use uint16


Summary of changes:
 epan/dissectors/packet-rdm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)