Wireshark-commits: [Wireshark-commits] master 301a5b7c: Eliminate proto_tree_add_text from some dis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 9 Dec 2014 05:57:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=301a5b7ceac60d0569ce1717e839241d10724003
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

301a5b7c by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some dissectors.
    
    Change-Id: I44cc6b70ec4dfc565934da499f46fca60a4ded93
    Reviewed-on: https://code.wireshark.org/review/5524
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1952fef   SCTP: Missing break in switch (CID 1135556)
    adds  301a5b7c  Eliminate proto_tree_add_text from some dissectors.


Summary of changes:
 epan/dissectors/packet-isis-clv.c           |  121 +++++---------------
 epan/dissectors/packet-isis-clv.h           |   12 +-
 epan/dissectors/packet-isis-hello.c         |  143 +++++++++++++-----------
 epan/dissectors/packet-isis-lsp.c           |   71 ++++++++----
 epan/dissectors/packet-isis-snp.c           |   37 +++++--
 epan/dissectors/packet-mpls.c               |   28 +++--
 epan/dissectors/packet-netflow.c            |   81 ++++++++------
 epan/dissectors/packet-nsip.c               |   23 +++-
 epan/dissectors/packet-radius_packetcable.c |  158 ++++++++++++++++-----------
 epan/dissectors/packet-rmi.c                |   49 +++++----
 epan/dissectors/packet-rtsp.c               |   11 +-
 11 files changed, 406 insertions(+), 328 deletions(-)