Wireshark-commits: [Wireshark-commits] master-1.12 11f007b: Strengthen association matching when we
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Dec 2014 14:56:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11f007b802008ba561edf90cf81f4a9f17c715d6
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

11f007b by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Strengthen association matching when we haven't seen the INIT/INIT-ACK.
    
    The fact that the vtag matches the initiate tag doesn't mean much if both are 0
    (uninitialized).
    
    Also leave in some (commented-out) debug to make debugging this stuff easier
    in the future.
    
    Change-Id: Id007de8bf9d2d4e0bb18309ed3e2572fedda45f1
    Reviewed-on: https://code.wireshark.org/review/5571
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    (cherry picked from commit 18fabb4733336896f94e3a785f0f7c663ff9ae72)
    Reviewed-on: https://code.wireshark.org/review/5629
    

Actions performed:

    from  5d327f2   mausb: Rename expert filter names to fix dup filter names
    adds  11f007b   Strengthen association matching when we haven't seen the INIT/INIT-ACK.


Summary of changes:
 epan/dissectors/packet-sctp.c |   43 +++++++++++++++++++++++++----------------
 1 file changed, 26 insertions(+), 17 deletions(-)