Wireshark-commits: [Wireshark-commits] master e77507b: Use proto_tree_add_bitmask for groups of pro
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 1 Dec 2014 12:18:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e77507b0eac903e74389ef1bf2dfa51d4cf00aad
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e77507b by Michael Mann (mmann78@xxxxxxxxxxxx):

    Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
    
    Part 3 of many, but this concludes the strict conversion to proto_tree_add_bitmask.  Patches to follow with use proto_tree_add_bitmask_xxx (some functions still need to be written)
    
    Change-Id: Ic2435667c6a7f1d40602124e5044954d2a296180
    Reviewed-on: https://code.wireshark.org/review/5553
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  542439e   SNA: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  e77507b   Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.


Summary of changes:
 asn1/spnego/packet-spnego-template.c        |   26 +-
 epan/dissectors/packet-oampdu.c             |   78 +-
 epan/dissectors/packet-pcep.c               |   24 +-
 epan/dissectors/packet-ppp.c                |  102 ++-
 epan/dissectors/packet-q2931.c              |   37 +-
 epan/dissectors/packet-q933.c               |   12 +-
 epan/dissectors/packet-radius_packetcable.c |    1 +
 epan/dissectors/packet-rsvp.c               |   43 +-
 epan/dissectors/packet-rx.c                 |   33 +-
 epan/dissectors/packet-ses.c                |  275 +++----
 epan/dissectors/packet-smb-browse.c         |   82 +--
 epan/dissectors/packet-smb-direct.c         |   15 +-
 epan/dissectors/packet-smb.c                | 1024 +++++++++------------------
 epan/dissectors/packet-smb2.c               |   89 +--
 epan/dissectors/packet-sna.c                |   26 +-
 epan/dissectors/packet-spnego.c             |   50 +-
 epan/dissectors/packet-srvloc.c             |   48 +-
 epan/dissectors/packet-telnet.c             |    5 +-
 epan/dissectors/packet-tr.c                 |   28 +-
 epan/dissectors/packet-usb-video.c          |   14 +-
 epan/dissectors/packet-winsrepl.c           |   18 +-
 epan/dissectors/packet-wsp.c                |   65 +-
 epan/dissectors/packet-ypserv.c             |   14 +-
 epan/dissectors/packet-zbee-nwk.c           |   40 +-
 epan/dissectors/packet-zbee-zcl.c           |   32 +-
 epan/dissectors/packet-zebra.c              |   28 +-
 26 files changed, 806 insertions(+), 1403 deletions(-)