| December 01, 2014 | 
| 00:31 | 
[Wireshark-commits] master 846bb53: Add a Buffer to wtap_pkthdr to hold file-type-specific packet metadata. | 
Wireshark code review | 
 | 
| 00:38 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 00:38 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 00:43 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 00:51 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 00:54 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 00:56 | 
[Wireshark-commits] master 18f0109: qt: fix use-after-free pattern | 
Wireshark code review | 
 | 
| 00:57 | 
[Wireshark-commits] master ff18b35: Fix compile error. | 
Wireshark code review | 
 | 
| 01:00 | 
[Wireshark-commits] master cc0b083: Squelch a compiler warning. | 
Wireshark code review | 
 | 
| 01:02 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis | 
buildbot-no-reply | 
 | 
| 01:03 | 
[Wireshark-commits] master 0cf2f74: Squelch another compiler	warning. | 
Wireshark code review | 
 | 
| 01:13 | 
[Wireshark-commits] master cd14ff3: qt: use qstring_strdup | 
Wireshark code review | 
 | 
| 03:43 | 
[Wireshark-commits] master 90977c7: Update display filter names per	checkfiltername.pl | 
Wireshark code review | 
 | 
| 05:43 | 
[Wireshark-commits] master 86c659c: Improve checkfiltername.pl for	pre-commit script. | 
Wireshark code review | 
 | 
| 08:52 | 
[Wireshark-commits] master 4f9af86: Use proto_tree_add_bitmask for groups of proto_tree_add_boolean. | 
Wireshark code review | 
 | 
| 08:54 | 
[Wireshark-commits] master 0415df8: Asterix: fix Coverity scan (1025624 & 1025625: Missing break in switch) | 
Wireshark code review | 
 | 
| 10:07 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 11:51 | 
[Wireshark-commits] master 542439e: SNA: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang | 
Wireshark code review | 
 | 
| 12:18 | 
[Wireshark-commits] master e77507b: Use proto_tree_add_bitmask for groups of proto_tree_add_boolean. | 
Wireshark code review | 
 | 
| 14:05 | 
[Wireshark-commits] master 6d207fe: Remove private_data member from packet_info structure. | 
Wireshark code review | 
 | 
| 18:57 | 
[Wireshark-commits] master 05c1aa2: BGP: fix dissection of BGP	community tag | 
Wireshark code review | 
 | 
| 18:58 | 
[Wireshark-commits] master-1.12 8b791bb: BGP: fix dissection of BGP	community tag | 
Wireshark code review | 
 | 
| December 02, 2014 | 
| 02:27 | 
[Wireshark-commits] master d643325: alljoyn: Rename some filters;	Fix some filter types. | 
Wireshark code review | 
 | 
| 04:11 | 
[Wireshark-commits] master 9441909: dftest: load plugins so plugin display filters can also be tested. | 
Wireshark code review | 
 | 
| 05:42 | 
[Wireshark-commits] master 325014a: multipart: Don't include	boundary in preamble. | 
Wireshark code review | 
 | 
| 05:42 | 
[Wireshark-commits] master 5eec6bb: multipart: Handle	multipart/signed | 
Wireshark code review | 
 | 
| 09:38 | 
[Wireshark-commits] master f260f9a: BGP: Incorrect decoding AS numbers when mixed AS size | 
Wireshark code review | 
 | 
| 09:39 | 
[Wireshark-commits] master-1.12 77afcab: BGP: Incorrect decoding AS numbers when mixed AS size | 
Wireshark code review | 
 | 
| 09:43 | 
[Wireshark-commits] master 987383d: 6LoWPAN: use manually managed memory for the stateful address decompression preferences | 
Wireshark code review | 
 | 
| 10:07 | 
[Wireshark-commits] master-1.12 63df178: 6LoWPAN: use manually managed memory for the stateful address decompression preferences | 
Wireshark code review | 
 | 
| 11:59 | 
[Wireshark-commits] master 9c05b7f: Make it possible to register an OID dissector to dissect ManagementExtension. | 
Wireshark code review | 
 | 
| 12:20 | 
[Wireshark-commits] master 485399a: Update Couchbase dissector | 
Wireshark code review | 
 | 
| 12:22 | 
[Wireshark-commits] master 077b45e: imf: Added base64 content	encoding support | 
Wireshark code review | 
 | 
| 12:23 | 
[Wireshark-commits] master f6a4f32: cms: Handle media_type pkcs7-mime and pkcs7-signature | 
Wireshark code review | 
 | 
| 13:23 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 13:45 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 14:04 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 14:33 | 
[Wireshark-commits] master d5aa8a4: Couchbase: fix Extended value string 'opcode_vals' forced to fall back to linear search | 
Wireshark code review | 
 | 
| 14:57 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis | 
buildbot-no-reply | 
 | 
| 15:10 | 
[Wireshark-commits] master 5abfc60: Couchbase: fix missing comma... | 
Wireshark code review | 
 | 
| 21:24 | 
[Wireshark-commits] master 43e759e: L2TP: add dissection of H bits | 
Wireshark code review | 
 | 
| 22:40 | 
[Wireshark-commits] master c681091: Fix instances of duplicate display-filter-names with incompatible types. | 
Wireshark code review | 
 | 
| December 03, 2014 | 
| 06:20 | 
[Wireshark-commits] master cff44e5: Always install icons, and install them under $(datadir). | 
Wireshark code review | 
 | 
| 06:21 | 
[Wireshark-commits] master b5a52ee: Get rid of trailing blank. | 
Wireshark code review | 
 | 
| 06:56 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 08:18 | 
[Wireshark-commits] master d6d55b2: Uninstall the icons with "make	uninstall". | 
Wireshark code review | 
 | 
| 08:23 | 
[Wireshark-commits] master fb0999a: Use $(srcdir) when installing	image/wsicon.svg. | 
Wireshark code review | 
 | 
| 09:00 | 
[Wireshark-commits] master e55fe95: Make dissect_sip_tcp() a new	style dissector. | 
Wireshark code review | 
 | 
| 09:02 | 
[Wireshark-commits] master 08c0247: Support dissecting REAL (BER)	data values | 
Wireshark code review | 
 | 
| 09:06 | 
[Wireshark-commits] master c69ccab: Install the other desktop files with "make install" as well. | 
Wireshark code review | 
 | 
| 09:12 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 09:13 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 09:13 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Solaris 10 SPARC | 
buildbot-no-reply | 
 | 
| 09:19 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 11:55 | 
[Wireshark-commits] master c4602e1: elf: fix .eh_frame parsing, add expert info for bad CIE length | 
Wireshark code review | 
 | 
| 11:59 | 
[Wireshark-commits] master db462ce: Try to please the buildboots by plasing th '#' at the begining of the line. | 
Wireshark code review | 
 | 
| 16:53 | 
[Wireshark-commits] master-1.12 c5e2624: Fix a number of dup hf[] filter-names probably resulting from cut/paste errs. | 
Wireshark code review | 
 | 
| 16:55 | 
[Wireshark-commits] master-1.12 55d15ca: Fix a number of dup hf[] filter-names probably mostly resulting from cut/paste errs | 
Wireshark code review | 
 | 
| 16:56 | 
[Wireshark-commits] master-1.12 1896a02: ieee80211; Rename some hf[] display filter names to fix dups and for clarity. | 
Wireshark code review | 
 | 
| 16:56 | 
[Wireshark-commits] master-1.12 8e3a58c: Rename some hf[] display filter names to fix dups. | 
Wireshark code review | 
 | 
| 16:56 | 
[Wireshark-commits] master-1.12 bb5419b: alljoyn: Rename some filters; Fix some filter types. | 
Wireshark code review | 
 | 
| 16:57 | 
[Wireshark-commits] master-1.12 cfa3bd7: Fix instances of duplicate display-filter-names with incompatible types. | 
Wireshark code review | 
 | 
| 19:04 | 
[Wireshark-commits] master b088ca5: Squelch some "can't happen in	reality" warnings. | 
Wireshark code review | 
 | 
| 19:51 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 21:30 | 
[Wireshark-commits] master ee48194: start dissecting the mvhd box | 
Wireshark code review | 
 | 
| 21:30 | 
[Wireshark-commits] master 2f39f2e: BOX_TYPE_STZ2 | 
Wireshark code review | 
 | 
| 21:31 | 
[Wireshark-commits] master 0a30f68: start dissecting the stsz box | 
Wireshark code review | 
 | 
| 22:00 | 
[Wireshark-commits] master c86d1d2: FC: fix dissection when packets are captured with Fibre Channel FC-2 encapsulation type | 
Wireshark code review | 
 | 
| 22:06 | 
[Wireshark-commits] master 7ef5abc: Don't run gtk-update-icon-cache when uninstalling the Qt package. But do run it when installing the gnome package. | 
Wireshark code review | 
 | 
| 22:13 | 
[Wireshark-commits] master-1.12 ba26505: FC: fix dissection when packets are captured with Fibre Channel FC-2 encapsulation type | 
Wireshark code review | 
 | 
| 22:49 | 
[Wireshark-commits] master-1.12 e08b715: Don't run gtk-update-icon-cache when uninstalling the Qt package. But do run it when installing the gnome package. | 
Wireshark code review | 
 | 
| 23:38 | 
[Wireshark-commits] master 0d20456: Make a note that cmake needs to install the freedesktop integration files too. | 
Wireshark code review | 
 | 
| December 04, 2014 | 
| 00:16 | 
[Wireshark-commits] master f0bd311: CMake: Don't cache	LUA_LIBRARIES. | 
Wireshark code review | 
 | 
| 01:19 | 
[Wireshark-commits] master-1.12 22852e7: Tell the loader where to find our libraries if we're being installed someplace other than /usr . | 
Wireshark code review | 
 | 
| 01:19 | 
[Wireshark-commits] master 44e2716: Tell the loader where to find our libraries if we're being installed someplace other than /usr . | 
Wireshark code review | 
 | 
| 02:24 | 
[Wireshark-commits] master 1ffe32b: Fix building of RPMs and get RPM builds working with a prefix other than /usr again. | 
Wireshark code review | 
 | 
| 02:38 | 
[Wireshark-commits] master 245bdd1: Put a bunch of suggestions in post-install/post-uninstall hooks. | 
Wireshark code review | 
 | 
| 03:43 | 
[Wireshark-commits] master d519617: mausb: Rename expert filter names to fix dup filter names. | 
Wireshark code review | 
 | 
| 03:44 | 
[Wireshark-commits] master f8c0bff: mac-lte: Rename expert filter name to fix conflict with same name in hf[] | 
Wireshark code review | 
 | 
| 03:44 | 
[Wireshark-commits] master 6e5d84f: Rename some filter names to fix cases of duplicate filter names. | 
Wireshark code review | 
 | 
| 03:45 | 
[Wireshark-commits] master-1.12 1e5676d: mac-lte: Rename expert filter name to fix conflict with same name in hf[] | 
Wireshark code review | 
 | 
| 03:46 | 
[Wireshark-commits] master-1.12 1651182: Rename some filter names to fix cases of duplicate filter names. | 
Wireshark code review | 
 | 
| 04:08 | 
[Wireshark-commits] master-1.12 5d327f2: mausb: Rename expert filter names to fix dup filter names | 
Wireshark code review | 
 | 
| 07:56 | 
[Wireshark-commits] master c02417f: Don't do all the fd.o desktop integration stuff on OS X. | 
Wireshark code review | 
 | 
| 08:03 | 
[Wireshark-commits] master b8a2364: Don't do the desktop integration stuff if we're not building Wireshark. | 
Wireshark code review | 
 | 
| 09:04 | 
[Wireshark-commits] master f27c345: Add resource-id parsing to the X11 errors that return it | 
Wireshark code review | 
 | 
| 09:06 | 
[Wireshark-commits] master a919566: BACnet: fix dissection of exception-schedule property. | 
Wireshark code review | 
 | 
| 14:05 | 
[Wireshark-commits] master b2fcbb2: Add a MIME type for Tektronix rf5 files and register Wireshark for that type of file. | 
Wireshark code review | 
 | 
| 14:56 | 
[Wireshark-commits] master ab3c182: There's no need to talk about update-alternatives here. | 
Wireshark code review | 
 | 
| 15:26 | 
[Wireshark-commits] master 70ca52c: 3GPP: upgrade 2G/3G NAS dissector to v12.7.0 and NAS EPS dissector to v12.6.0 | 
Wireshark code review | 
 | 
| 22:05 | 
[Wireshark-commits] master 73f48a0: dont't manually throw a ReportedBoundsError if the packet is empty use tvb_captured_length() instead of tvb_length() | 
Wireshark code review | 
 | 
| 22:06 | 
[Wireshark-commits] master 5d95067: simplify dissect_i2c() | 
Wireshark code review | 
 | 
| 22:06 | 
[Wireshark-commits] master 3b7c165: use the same data types as in	i2c_phdr | 
Wireshark code review | 
 | 
| 23:54 | 
[Wireshark-commits] master d5a4cc3: Make autogen.sh look for "python3" if "python" isn't found before giving up. | 
Wireshark code review | 
 | 
| December 05, 2014 | 
| 00:00 | 
[Wireshark-commits] master 0867344: Look for python3 in addition to python in configure script. | 
Wireshark code review | 
 | 
| 14:15 | 
[Wireshark-commits] master 18fabb4: Strengthen association matching when we haven't seen the INIT/INIT-ACK. | 
Wireshark code review | 
 | 
| 14:56 | 
[Wireshark-commits] master-1.12 11f007b: Strengthen association matching when we haven't seen the INIT/INIT-ACK. | 
Wireshark code review | 
 | 
| 21:05 | 
[Wireshark-commits] master b98c570: Fix varargs handling in	col_{add, append}_lstr(). | 
Wireshark code review | 
 | 
| 21:12 | 
[Wireshark-commits] master-1.12 ffb5fcf: Fix varargs handling in col_{add, append}_lstr(). | 
Wireshark code review | 
 | 
| 21:13 | 
[Wireshark-commits] master-1.12 20df4e3: Get rid of trailing blank. | 
Wireshark code review | 
 | 
| 21:14 | 
[Wireshark-commits] master 4510306: Get rid of a trailing blank. | 
Wireshark code review | 
 | 
| 23:47 | 
[Wireshark-commits] master bb00570: Fix some copy-and-pasteos in	error messages. | 
Wireshark code review | 
 | 
| 23:51 | 
[Wireshark-commits] master-1.12 5c8caa2: Fix some copy-and-pasteos	in error messages. | 
Wireshark code review | 
 | 
| December 06, 2014 | 
| 01:20 | 
[Wireshark-commits] master a5fe0d4: BT obex: Missing break in	switch (CID 1132031) | 
Wireshark code review | 
 | 
| 01:22 | 
[Wireshark-commits] master 646d52e: PCEP: Missing break in switch	(CID 1247685) | 
Wireshark code review | 
 | 
| 02:08 | 
[Wireshark-commits] master 8c190d6: RPKI-RTR: Missing break in	switch (CID 1233099) | 
Wireshark code review | 
 | 
| 04:54 | 
[Wireshark-commits] master 6d4c0ed: Don't go past the end of the	"extra data". | 
Wireshark code review | 
 | 
| 05:12 | 
[Wireshark-commits] master-1.12 b040f11: RPKI-RTR: Missing break in	switch (CID 1233099) | 
Wireshark code review | 
 | 
| 21:42 | 
[Wireshark-commits] master 22da8a3: Remove annex_a_used from	packet_info structure. | 
Wireshark code review | 
 | 
| December 07, 2014 | 
| 00:00 | 
[Wireshark-commits] master de61f06: The packet encapsulation is in pkt_encap, not rec_type. | 
Wireshark code review | 
 | 
| 16:05 | 
[Wireshark-commits] master afa5558: [Automatic manuf, services and enterprise-numbers update for 2014-12-07] | 
Wireshark code review | 
 | 
| 16:07 | 
[Wireshark-commits] master-1.12 3d492b1: [Automatic manuf, services and enterprise-numbers update for 2014-12-07] | 
Wireshark code review | 
 | 
| 16:10 | 
[Wireshark-commits] master-1.10 0ed5e1a: [Automatic manuf, services and enterprise-numbers update for 2014-12-07] | 
Wireshark code review | 
 | 
| 16:17 | 
[Wireshark-commits] master 1bc8791: Eliminate proto_tree_add_text	from packet-telnet.c | 
Wireshark code review | 
 | 
| 18:52 | 
[Wireshark-commits] master ade2bef: make sure that we don't read past the end of the compressed buffer | 
Wireshark code review | 
 | 
| 18:53 | 
[Wireshark-commits] master e456dec: don't initialize variables if the first thing we do is assign a different value to them | 
Wireshark code review | 
 | 
| 18:53 | 
[Wireshark-commits] master a68a3da: make our counting a bit clearer | 
Wireshark code review | 
 | 
| 19:07 | 
[Wireshark-commits] master fd087fb: AFS: Missing break in switch	(CID 280434 & 280435) | 
Wireshark code review | 
 | 
| 19:10 | 
[Wireshark-commits] master 9d8cb74: iec104: Missing break in switch	(CID 280459) | 
Wireshark code review | 
 | 
| 19:15 | 
[Wireshark-commits] master 42cdc2b: dcerpc: Missing break in switch (CID 280449 & 280450 & 284051) | 
Wireshark code review | 
 | 
| 19:20 | 
[Wireshark-commits] master 5f79940: Endpoint: wrong filter when select a SCTP endpoint (INVALID == a.x.y.z ...) | 
Wireshark code review | 
 | 
| 19:40 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 20:18 | 
[Wireshark-commits] master 212ba58: Add checks for	non-null-terminated strings. | 
Wireshark code review | 
 | 
| 20:23 | 
[Wireshark-commits] master-1.12 1237a15: Add checks for	non-null-terminated strings. | 
Wireshark code review | 
 | 
| 20:26 | 
[Wireshark-commits] master-1.10 acb0402: Add checks for	non-null-terminated strings. | 
Wireshark code review | 
 | 
| 20:34 | 
[Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.6	x64 | 
buildbot-no-reply | 
 | 
| 20:34 | 
[Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu	14.04 x64 | 
buildbot-no-reply | 
 | 
| 20:37 | 
[Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.5	x86 | 
buildbot-no-reply | 
 | 
| 20:37 | 
[Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows	8.1 x86 | 
buildbot-no-reply | 
 | 
| 20:46 | 
[Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 7	x64 | 
buildbot-no-reply | 
 | 
| 20:50 | 
[Wireshark-commits] master-1.10 725540f: 1.10 didn't have	WTAP_OPEN_ERROR. | 
Wireshark code review | 
 | 
| 21:54 | 
[Wireshark-commits] master-1.10 1b45990: Fix cut-and-pasteo. | 
Wireshark code review | 
 | 
| 22:55 | 
[Wireshark-commits] master-1.12 fc101c8: Fix copy-and-pasteo. | 
Wireshark code review | 
 | 
| 22:55 | 
[Wireshark-commits] master-1.12 36a4ab2: 1.12 didn't have	WTAP_OPEN_ERROR. | 
Wireshark code review | 
 | 
| December 08, 2014 | 
| 00:48 | 
[Wireshark-commits] master 58b7277: 802.11: Add ieee80211_supported_rates_vals_ext to be exported | 
Wireshark code review | 
 | 
| 00:54 | 
[Wireshark-commits] master f47bc26: CAPWAP: Add some IEE802.11 Message Element Type (RFC5416) | 
Wireshark code review | 
 | 
| 01:00 | 
[Wireshark-commits] master 75cdf92: 802.11: fix indent (use 2 spaces) and modelines for 802.11 h file | 
Wireshark code review | 
 | 
| 01:13 | 
[Wireshark-commits] master e172ebb: Add	proto_tree_add_bitmask_with_flags. | 
Wireshark code review | 
 | 
| 01:15 | 
[Wireshark-commits] master f16376e: Fix showing error dialog when calling vsimple_error_message_box() | 
Wireshark code review | 
 | 
| 08:53 | 
[Wireshark-commits] master 52df6ef: Try to improve reassembly when SIP PDU starts in the middle of a segment and continues trough the next segment(s). | 
Wireshark code review | 
 | 
| 10:43 | 
[Wireshark-commits] master 0bd79c5: Fix full name of NodeId namespace index field, was a copy&pase error | 
Wireshark code review | 
 | 
| 12:47 | 
[Wireshark-commits] master-1.12 2341031: Fix full name of NodeId namespace index field, was a copy&pase error | 
Wireshark code review | 
 | 
| 19:41 | 
[Wireshark-commits] master d5f771c: Use correct expression in a "length too short" message. | 
Wireshark code review | 
 | 
| 19:51 | 
[Wireshark-commits] master-1.12 d3fc196: Don't go past the end of	the "extra data". | 
Wireshark code review | 
 | 
| 20:11 | 
[Wireshark-commits] master-1.12 e50f138: Use correct expression in a "length too short" message. | 
Wireshark code review | 
 | 
| 20:13 | 
[Wireshark-commits] master-1.12 21fe891: Add a missing g_free(). | 
Wireshark code review | 
 | 
| 21:42 | 
[Wireshark-commits] master 08e624f: Remove an unnecessary include. | 
Wireshark code review | 
 | 
| 22:14 | 
[Wireshark-commits] master d87a952: It's a reasonable expectation that we will have C++ style comments in ui/qt. | 
Wireshark code review | 
 | 
| 23:21 | 
[Wireshark-commits] master 8a446e9: Add missing build-dependencies for the Debian package | 
Wireshark code review | 
 | 
| 23:26 | 
[Wireshark-commits] master ffcacae: Have different MTP2 dissectors for different metadata and CRC. | 
Wireshark code review | 
 | 
| 23:37 | 
[Wireshark-commits] master 32e1ff9: Don't put bitmasks under an	FT_NONE. | 
Wireshark code review | 
 | 
| December 09, 2014 | 
| 00:07 | 
[Wireshark-commits] master 260af59: Values in a value_string_ext	*must* be sorted. | 
Wireshark code review | 
 | 
| 00:14 | 
[Wireshark-commits] master f34bcb7: Don't put bitmasks under an	FT_NONE. | 
Wireshark code review | 
 | 
| 01:30 | 
[Wireshark-commits] master 3d95c62: Don't try to look in a	non-existent hash table. | 
Wireshark code review | 
 | 
| 03:25 | 
[Wireshark-commits] master 5c29704: LDAP's DirSyncFlags are a bitfield, so show it as an unsigned integer in hex. | 
Wireshark code review | 
 | 
| 03:57 | 
[Wireshark-commits] master 7b1c3ab: Manually fix a pidl bug - that field should be an FT_STRING. | 
Wireshark code review | 
 | 
| 04:05 | 
[Wireshark-commits] master fbf08cf: Nothing to free there. | 
Wireshark code review | 
 | 
| 05:55 | 
[Wireshark-commits] master 283e5c1: GVSP: Missing break in switch (CID 1247683 & 1247684) | 
Wireshark code review | 
 | 
| 05:56 | 
[Wireshark-commits] master 1952fef: SCTP: Missing break in switch	(CID 1135556) | 
Wireshark code review | 
 | 
| 05:57 | 
[Wireshark-commits] master 301a5b7c: Eliminate proto_tree_add_text	from some dissectors. | 
Wireshark code review | 
 | 
| 06:39 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Solaris 10 SPARC | 
buildbot-no-reply | 
 | 
| 06:41 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 06:52 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 07:10 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 07:18 | 
[Wireshark-commits] master e5757d1: Fix GTK warning in EXTCAP parts | 
Wireshark code review | 
 | 
| 08:55 | 
[Wireshark-commits] master 58fc89a: Fix copy-and-pasteo. | 
Wireshark code review | 
 | 
| 09:49 | 
[Wireshark-commits] master 74172ae: LTE: Update MAC and RLC	dissectors to Release 12 | 
Wireshark code review | 
 | 
| 14:16 | 
[Wireshark-commits] master-1.12 1569d87: Win: do not suggest user to install Qt development libraries | 
Wireshark code review | 
 | 
| 18:59 | 
[Wireshark-commits] master 9681bdd: Eliminate proto_tree_add_text	from packet-ppp.c. | 
Wireshark code review | 
 | 
| 19:02 | 
[Wireshark-commits] master bcaa5d8: Qt: Update and rename the	summary dialog. | 
Wireshark code review | 
 | 
| 19:26 | 
[Wireshark-commits] master f66de3a: Fix filename matching. | 
Wireshark code review | 
 | 
| 21:25 | 
[Wireshark-commits] master 3147087: Fix ranlib "has no symbols" errors in the codecs directory. | 
Wireshark code review | 
 | 
| 21:25 | 
[Wireshark-commits] master 4921e55: Qt: Initial VoIP Calls dialog. | 
Wireshark code review | 
 | 
| 21:55 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 22:48 | 
[Wireshark-commits] master 34cd063: LTE RRC: upgrade dissector to	v12.3.0 | 
Wireshark code review | 
 | 
| 23:15 | 
[Wireshark-commits] master c1d4a08: Add media playback icons. | 
Wireshark code review | 
 | 
| December 10, 2014 | 
| 01:51 | 
[Wireshark-commits] master e4b0141: Qt: Obey main toolbar icon	preferences. | 
Wireshark code review | 
 | 
| 04:08 | 
[Wireshark-commits] master 8375a66: nfs: fix failure to parse	EXCHANGE_ID arguments | 
Wireshark code review | 
 | 
| 04:19 | 
[Wireshark-commits] master dff05c9: nfs: decode dCache NFS file	handle | 
Wireshark code review | 
 | 
| 04:51 | 
[Wireshark-commits] master c449b43: nfs: expert...() shouldn't be called under 'if(tree)' | 
Wireshark code review | 
 | 
| 06:00 | 
[Wireshark-commits] master 4af7482: Eliminate proto_tree_add_text	from packet-icq.c | 
Wireshark code review | 
 | 
| 06:22 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 06:42 | 
[Wireshark-commits] master f64f7c6: NFS: do not duplicate field	name in blurb | 
Wireshark code review | 
 | 
| 06:42 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Solaris 10 SPARC | 
buildbot-no-reply | 
 | 
| 06:43 | 
[Wireshark-commits] master 1f8b16e: ICQ: fix icq.meta_user.found_authorization field registration | 
Wireshark code review | 
 | 
| 06:52 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 07:16 | 
[Wireshark-commits] master c46fa33: Riemann protocol dissector | 
Wireshark code review | 
 | 
| 07:18 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 07:23 | 
[Wireshark-commits] master bd8d2f5: packet-couchbase.c: dissect	more DCP commands | 
Wireshark code review | 
 | 
| 08:39 | 
[Wireshark-commits] master d4476b1: Expose	find_heur_dissector_list(). | 
Wireshark code review | 
 | 
| 08:50 | 
[Wireshark-commits] master e050ad2: Eliminate some	proto_tree_add_text in packet-bgp.c | 
Wireshark code review | 
 | 
| 09:04 | 
[Wireshark-commits] master a971768: Refactor "color" conversation	filters | 
Wireshark code review | 
 | 
| 17:36 | 
[Wireshark-commits] master 4c229ca: Build 1.99.1. | 
Wireshark code review | 
 | 
| 17:44 | 
[Wireshark-commits] [wireshark] annotated tag v1.99.1 created (now	ce9ae4c) | 
Wireshark code review | 
 | 
| 17:44 | 
[Wireshark-commits] [wireshark] annotated tag wireshark-1.99.1	created (now 4e142de) | 
Wireshark code review | 
 | 
| 19:17 | 
[Wireshark-commits]  master 3f08a85: 1.99.1 → 1.99.2. | 
Wireshark code review | 
 | 
| 19:18 | 
[Wireshark-commits] [wireshark] annotated tag v1.99.2rc0 created	(now 5c74911) | 
Wireshark code review | 
 | 
| 19:56 | 
[Wireshark-commits] master dc289d7: Update the release notes. | 
Wireshark code review | 
 | 
| 20:02 | 
[Wireshark-commits] master 0980dd5: GPRSCDR: fix warning: 'dissect_gprscdr_MBMSInformation' defined but not use | 
Wireshark code review | 
 | 
| 20:02 | 
[Wireshark-commits] master 088e5fe: GPRSCDR: Remove from Dirty ASN1	list | 
Wireshark code review | 
 | 
| 20:03 | 
[Wireshark-commits] master 2f8030f: LCSAP: fix dissection of negative longitude and latitude | 
Wireshark code review | 
 | 
| 20:57 | 
[Wireshark-commits] master-1.12 adee1a4: LCSAP: fix dissection of negative longitude and latitude | 
Wireshark code review | 
 | 
| 20:57 | 
[Wireshark-commits] master-1.10 f0929ec: LCSAP: fix dissection of negative longitude and latitude | 
Wireshark code review | 
 | 
| 21:56 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| December 11, 2014 | 
| 00:23 | 
[Wireshark-commits] master 144855c: Fix a comment. | 
Wireshark code review | 
 | 
| 01:51 | 
[Wireshark-commits] master 9855bef: Make the type of the second argument to a DATFunc_heur_table explicit. | 
Wireshark code review | 
 | 
| 03:05 | 
[Wireshark-commits] master 151164d: Give dissector_all_heur_tables_foreach_table() a sort function. | 
Wireshark code review | 
 | 
| 04:16 | 
[Wireshark-commits] master 339df3d: Add a	heur_dissector_table_foreach() function. | 
Wireshark code review | 
 | 
| 09:33 | 
[Wireshark-commits] master 5570f8e: [SIP] Try to fix another corner	case of reassembly. | 
Wireshark code review | 
 | 
| 09:39 | 
[Wireshark-commits] master b7f8cd8: skip the extra field in the gzip header it consists of two bytes xsize + xsize bytes of data | 
Wireshark code review | 
 | 
| 12:09 | 
[Wireshark-commits] master def4313: 6lowpan : fix warning: no previous prototype for 'lowpan_context_free' [-Wmissing-prototypes] | 
Wireshark code review | 
 | 
| 12:09 | 
[Wireshark-commits] master 230ce30: GSM bssmap le: fix warning: no previous prototype for 'dissect_bssmap_le' [-Wmissing-prototypes] | 
Wireshark code review | 
 | 
| 12:16 | 
[Wireshark-commits] master 772fbfb: GSM a BSSMAP : fix warning: no previous prototype for 'dissect_bssmap' [-Wmissing-prototypes] | 
Wireshark code review | 
 | 
| 12:18 | 
[Wireshark-commits] master 7d905be: GSM BSSMAP LE: fix indent (use	tabs) | 
Wireshark code review | 
 | 
| 13:55 | 
[Wireshark-commits] master 9036f09: BGP: extract the bgp path attribute dissection to a dedicated function. | 
Wireshark code review | 
 | 
| 13:55 | 
[Wireshark-commits] master 0ef1aef: BGP: add support of RFC6368 - Internal BGP as the Provider/Customer Edge Protocol for BGP/MPLS IP Virtual Private Networks (VPNs). | 
Wireshark code review | 
 | 
| 19:07 | 
[Wireshark-commits] master 8f56378: rsvp: Fix dup display-filter name possibly leading to crash if used. | 
Wireshark code review | 
 | 
| 19:08 | 
[Wireshark-commits] master 425bc30: eth, mp2t: Rename ei[] filter names duplicating hf[] filter names. | 
Wireshark code review | 
 | 
| 21:41 | 
[Wireshark-commits] master 1ce64e7: CMake: Make it easier to generate the release notes & NEWS. | 
Wireshark code review | 
 | 
| 22:49 | 
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test | 
buildbot-no-reply | 
 | 
| 23:15 | 
[Wireshark-commits] master bd4d291: Qt: Move Follow TCP, UDP, SSL to a Follow folder (like when right click) | 
Wireshark code review | 
 | 
| December 12, 2014 | 
| 12:54 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Clang Code Analysis | 
buildbot-no-reply | 
 | 
| 12:56 | 
[Wireshark-commits] master a2a6e31: Riemann: fix "Decode as" feature | 
Wireshark code review | 
 | 
| 13:06 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 13:06 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 13:17 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 14:26 | 
[Wireshark-commits] master 8e96830: LPP: avoid doing an out of bound access in case the PER decoding gives an invalid value | 
Wireshark code review | 
 | 
| 14:28 | 
[Wireshark-commits] master-1.12 edc1a29: LPP: avoid doing an out of bound access in case the PER decoding gives an invalid value | 
Wireshark code review | 
 | 
| 15:31 | 
[Wireshark-commits] master 76c5568: Riemann: fix compilation | 
Wireshark code review | 
 | 
| 15:31 | 
[Wireshark-commits] master 29c1b58: rsvp: Convert encoding-arg ENC_NA to ENC_BIG_ENDIAN for all integer fields | 
Wireshark code review | 
 | 
| 15:33 | 
[Wireshark-commits] master 64cb510: Change ENC_NA to ENC_BIG_ENDIAN for all fetches of integral type fields. | 
Wireshark code review | 
 | 
| 16:30 | 
[Wireshark-commits] master 2898f13: cip: Access FT_UINT16 hf_cip_sc_create_instance with proper encoding-arg. | 
Wireshark code review | 
 | 
| 20:40 | 
[Wireshark-commits] master 56697c2: Qt: Add name resolution menu	items. | 
Wireshark code review | 
 | 
| 21:25 | 
[Wireshark-commits] master 33c26a0: doc: remove some references to the now defunct python support | 
Wireshark code review | 
 | 
| December 13, 2014 | 
| 00:16 | 
[Wireshark-commits] master b0cdee6: DNS: Remove whitespace on DNS Col info before type name | 
Wireshark code review | 
 | 
| 00:17 | 
[Wireshark-commits] master 5d6eb80: Use g_direct_ functions for hash tables where possible | 
Wireshark code review | 
 | 
| 07:17 | 
[Wireshark-commits] master cc12c72: Riemann: add support for TCP	transport | 
Wireshark code review | 
 | 
| 16:36 | 
[Wireshark-commits] master 80d44af: dissector_try_uint(_new) and dissector_try_string now return the number of bytes consumed | 
Wireshark code review | 
 | 
| 16:42 | 
[Wireshark-commits] master 758ec16: GSM SMS: fix (U)SIM Data	Download Class 2 dissection | 
Wireshark code review | 
 | 
| 17:15 | 
[Wireshark-commits] master 21d6ed4: fix compile error | 
Wireshark code review | 
 | 
| 17:17 | 
[Wireshark-commits] master 7592d39: GSM SMS: fix 'msg_class' may be used uninitialized in this function warning | 
Wireshark code review | 
 | 
| 17:33 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 18:46 | 
[Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... | 
Wireshark code review | 
 | 
| 18:53 | 
[Wireshark-commits] master ae844d9: gsm_sms: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields | 
Wireshark code review | 
 | 
| 21:28 | 
[Wireshark-commits] master ff46ac5: rfid-pn532.c: Use FT_UINT24 to display complete hex value for three 3-byte fields. | 
Wireshark code review | 
 | 
| 21:59 | 
[Wireshark-commits] master 94d7e8d: Use ENC_LITTLE_ENDIAN when fetching FT_U?INT8 fields ... | 
Wireshark code review | 
 | 
| 21:59 | 
[Wireshark-commits] master 5992ef4: plugins: replace ENC_NA by ENC_..._ENDIAN when fetching integral types | 
Wireshark code review | 
 | 
| 22:00 | 
[Wireshark-commits] master 1725eee: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... | 
Wireshark code review | 
 | 
| December 14, 2014 | 
| 16:05 | 
[Wireshark-commits] master 85ed008: [Automatic manuf, services and enterprise-numbers update for 2014-12-14] | 
Wireshark code review | 
 | 
| 16:07 | 
[Wireshark-commits] master-1.12 14be588: [Automatic manuf, services and enterprise-numbers update for 2014-12-14] | 
Wireshark code review | 
 | 
| 16:09 | 
[Wireshark-commits] master-1.10 fd7e355: [Automatic manuf, services and enterprise-numbers update for 2014-12-14] | 
Wireshark code review | 
 | 
| 17:53 | 
[Wireshark-commits] master 44e14b7: Qt: Defer startup messages. | 
Wireshark code review | 
 | 
| 18:03 | 
[Wireshark-commits] master e9f9683: GSM SMS: fix dissection of	Character Set IE | 
Wireshark code review | 
 | 
| 18:43 | 
[Wireshark-commits] master 16f38e9: Kerberos: import KRB5_AD_WIN2K_PAC dissection from old non ASN.1 based dissector | 
Wireshark code review | 
 | 
| 22:37 | 
[Wireshark-commits] master 9815dc1: Add support for EAPOL-MKA	(802.1x-2010) | 
Wireshark code review | 
 | 
| December 15, 2014 | 
| 07:58 | 
[Wireshark-commits] master 6919734: HTTP2: Update nghttp2 lib	(0.6.7) | 
Wireshark code review | 
 | 
| 13:19 | 
[Wireshark-commits] master-1.12 1416248: Don't assert out on tvb_memcpy() with a null data pointer if the length is 0. | 
Wireshark code review | 
 | 
| 14:24 | 
[Wireshark-commits] master fddbbdd: Translates: Update Polish	translation | 
Wireshark code review | 
 | 
| 14:25 | 
[Wireshark-commits] master 657e42b: cmake: Do not hide possible options for other platforms | 
Wireshark code review | 
 | 
| 14:25 | 
[Wireshark-commits] master 79d6a15: Bluetooth: BTLE: SN, NESN should be numbers not booleans | 
Wireshark code review | 
 | 
| 14:25 | 
[Wireshark-commits] master afacb1c: Bluetooth: Fix CRC Init length	in Ubertooth | 
Wireshark code review | 
 | 
| 14:27 | 
[Wireshark-commits] master a89c17f: Bluetooth: BTLE: Add src/dst addresses when they are known | 
Wireshark code review | 
 | 
| 14:35 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 14:36 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 14:36 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 14:37 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Solaris 10 SPARC | 
buildbot-no-reply | 
 | 
| 14:38 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 14:44 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 14:51 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis | 
buildbot-no-reply | 
 | 
| 15:33 | 
[Wireshark-commits] master dab9f76: [ISUP] Add dissection of Japan TTC EMERGENCY CALL INDICATOR | 
Wireshark code review | 
 | 
| 16:48 | 
[Wireshark-commits] master c504772: Revert "Bluetooth: BTLE: Add src/dst addresses when they are known" | 
Wireshark code review | 
 | 
| 17:30 | 
[Wireshark-commits] master 27095f9: Add Bug 10488 (multiple capture files) to the release notes. | 
Wireshark code review | 
 | 
| 21:09 | 
[Wireshark-commits] master fafa686: Enable case-insensitive string	dissector tables | 
Wireshark code review | 
 | 
| 22:05 | 
[Wireshark-commits] master 82e6304: MP4: fix Unused entry: epan/dissectors/file-mp4.c, hf_mp4_stsd_entry_cnt | 
Wireshark code review | 
 | 
| 22:12 | 
[Wireshark-commits] master 9187456: MP4: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang > 3.3 | 
Wireshark code review | 
 | 
| 22:12 | 
[Wireshark-commits] master e709a34: exit if the key wasn't found in	the parameters list | 
Wireshark code review | 
 | 
| December 16, 2014 | 
| 09:14 | 
[Wireshark-commits] master 84c6c74: ISIS LSP: Add Segment Routing Capabilities Sub-TLV dissection | 
Wireshark code review | 
 | 
| 09:15 | 
[Wireshark-commits] master 8d1a555: ISIS LSP: Add Segment Routing Algorithm Sub TLV dissection | 
Wireshark code review | 
 | 
| 09:18 | 
[Wireshark-commits] master ec28d87: Riemann: attach metric_d field	to parent event | 
Wireshark code review | 
 | 
| 14:18 | 
[Wireshark-commits] master ce68707: Add cmake helper files for	finding wireshark | 
Wireshark code review | 
 | 
| 14:55 | 
[Wireshark-commits] master 1cbf951: HTTP2: Update to draft-16 | 
Wireshark code review | 
 | 
| 15:02 | 
[Wireshark-commits] master-1.10 be343af: Don't assert out on tvb_memcpy() with a null data pointer if the length is 0. | 
Wireshark code review | 
 | 
| 15:05 | 
[Wireshark-commits] master db93414: RDM: Mode verbose decoding of parameter IDs. -> I don't see why they were uint8; ANSI E1.33 and ANSI E1.20 use uint16 | 
Wireshark code review | 
 | 
| 15:05 | 
[Wireshark-commits] master-1.12 c9a6d31: RDM: Mode verbose decoding of parameter IDs. -> I don't see why they were uint8; ANSI E1.33 and ANSI E1.20 use uint16 | 
Wireshark code review | 
 | 
| 15:06 | 
[Wireshark-commits] master-1.10 12fd114: RDM: Mode verbose decoding of parameter IDs. -> I don't see why they were uint8; ANSI E1.33 and ANSI E1.20 use uint16 | 
Wireshark code review | 
 | 
| 15:23 | 
[Wireshark-commits] master 6ee78f3: http: properly calculate end of	chunked response | 
Wireshark code review | 
 | 
| 16:05 | 
[Wireshark-commits] master 972d347: Add Wireshark_LIBRARY variable | 
Wireshark code review | 
 | 
| 19:23 | 
[Wireshark-commits] master f400252: Disable the MDS Header	ethertype preference. | 
Wireshark code review | 
 | 
| 23:09 | 
[Wireshark-commits] master ad299df: HiSLIP: disable heuristic	dissector by default | 
Wireshark code review | 
 | 
| December 17, 2014 | 
| 05:36 | 
[Wireshark-commits] master 625ba02: Clean up handling of files without a known encapsulation. | 
Wireshark code review | 
 | 
| 06:08 | 
[Wireshark-commits] master b56d4d0: Clean up the "unknown per-packet encapsulation" message. | 
Wireshark code review | 
 | 
| 06:23 | 
[Wireshark-commits] master 40f69b2: Use WTAP_ERR_UNSUPPORTED for input file stuff we can't handle. | 
Wireshark code review | 
 | 
| 06:26 | 
[Wireshark-commits] master-1.12 c3321fc: Use WTAP_ERR_UNSUPPORTED for input file stuff we can't handle. | 
Wireshark code review | 
 | 
| 06:30 | 
[Wireshark-commits] master-1.10 5315b31: Use WTAP_ERR_UNSUPPORTED for input file stuff we can't handle. | 
Wireshark code review | 
 | 
| 06:41 | 
[Wireshark-commits] master dbdcae8: Rename WTAP_ERR_UNSUPPORTED_ENCAP to WTAP_ERR_UNWRITABLE_ENCAP. | 
Wireshark code review | 
 | 
| 08:31 | 
[Wireshark-commits] master ddcc2ae: Rename WTAP_ERR_UNSUPPORTED_FILE_TYPE to WTAP_ERR_UNWRITABLE_FILE_TYPE. | 
Wireshark code review | 
 | 
| 08:48 | 
[Wireshark-commits] master d2eddde: Report WTAP_ERR_UNSUPPORTED	correctly. | 
Wireshark code review | 
 | 
| 08:48 | 
[Wireshark-commits] master-1.12 940e24a: Report	WTAP_ERR_UNSUPPORTED correctly. | 
Wireshark code review | 
 | 
| 08:48 | 
[Wireshark-commits] master-1.10 982393b: Report	WTAP_ERR_UNSUPPORTED correctly. | 
Wireshark code review | 
 | 
| 09:03 | 
[Wireshark-commits] master c083f50: Install GLib cmake helper files | 
Wireshark code review | 
 | 
| 09:05 | 
[Wireshark-commits] master fb01f59: Use FindAsn2Wrs to find	asn2wrs.py | 
Wireshark code review | 
 | 
| 09:05 | 
[Wireshark-commits] master a1d4c0a: Do not force the output	directory | 
Wireshark code review | 
 | 
| 09:06 | 
[Wireshark-commits] master cc8ed84: Invoke asn2wrs.py using a	custom command | 
Wireshark code review | 
 | 
| 11:46 | 
[Wireshark-commits] master c5b7207: Install cmake files to make them available for out of source builds | 
Wireshark code review | 
 | 
| 11:53 | 
[Wireshark-commits] master df639f5: Fixed bug in ZigBee (zbee) decryption, added Key Establishment cluster and moved IAS, Thermostat and Poll clusters out of the ZCL foundation dissector. | 
Wireshark code review | 
 | 
| 12:26 | 
[Wireshark-commits] master d99fe21: Update to V12.5.0 | 
Wireshark code review | 
 | 
| 12:28 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 12:58 | 
[Wireshark-commits] master 8ccdc07: mip: fix (what appear to be) bugs in CVSE GRE key extension dissection | 
Wireshark code review | 
 | 
| 12:59 | 
[Wireshark-commits] master a3510cc: mip: Fix Rev Revocation [Ack]	Flags dissection bugs. | 
Wireshark code review | 
 | 
| 13:01 | 
[Wireshark-commits] master 6b7a395: Adding fix to convert latitude/longitude degrees to floating point format from fixed point format | 
Wireshark code review | 
 | 
| 13:10 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 13:30 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Solaris 10 SPARC | 
buildbot-no-reply | 
 | 
| 13:49 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 14:23 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 15:04 | 
[Wireshark-commits] master a13bbfc: [TCP] Don't attempt reassembly on retransmitted segments. | 
Wireshark code review | 
 | 
| 15:28 | 
[Wireshark-commits] master e4b4647: [MIP] Add refreence to 3GPP2 documents for 3GPP2 CVSE GRE_KEY_EXT | 
Wireshark code review | 
 | 
| 15:29 | 
[Wireshark-commits] master 24965c6: Fix missing space | 
Wireshark code review | 
 | 
| 18:26 | 
[Wireshark-commits] master 2018404: RDM: Made PID array global (can be reused in packet-artnet.c) Fixed deprecated API warning | 
Wireshark code review | 
 | 
| 18:27 | 
[Wireshark-commits] master 97cc005: Artnet3 and OEM Codes Update - Improved handling of status bits - Using bitfields where applicable - Unified capitalization of hex values - Using TFS instead of bits for status flags - Added universe ID calculation from Address/Net/Port - Added RDM PID decoding (values in packet-rdm.c) - Added Poll/PollReply/Toc/Rdm support for Artnet3 (15bit universe) - Updated manufacturer list from ESTA website - Updated OEM codes from Art-Net SDK | 
Wireshark code review | 
 | 
| 18:38 | 
[Wireshark-commits] master 2d6adb2: zbee-zcl: swap honeywell codes | 
Wireshark code review | 
 | 
| 19:54 | 
[Wireshark-commits] master e00f585: Fix another incorrect message for WTAP_ERR_UNSUPPORTED. | 
Wireshark code review | 
 | 
| 19:54 | 
[Wireshark-commits] master-1.12 bfb2b12: Fix another incorrect message for WTAP_ERR_UNSUPPORTED. | 
Wireshark code review | 
 | 
| 20:03 | 
[Wireshark-commits] master-1.10 7849e6b: Fix another incorrect message for WTAP_ERR_UNSUPPORTED. | 
Wireshark code review | 
 | 
| 20:39 | 
[Wireshark-commits] master db4232a: This code is used in Wireshark, not TShark; fix messages. | 
Wireshark code review | 
 | 
| 20:39 | 
[Wireshark-commits] master-1.12 c034118: This code is used in Wireshark, not TShark; fix messages. | 
Wireshark code review | 
 | 
| 20:40 | 
[Wireshark-commits] master-1.10 13227a0: This code is used in Wireshark, not TShark; fix messages. | 
Wireshark code review | 
 | 
| 21:36 | 
[Wireshark-commits] master 1a56990: Fix zbee errors introduced by change 5565, commit df639f509e812fff3c5eb4bdf4f77988c6ec122b | 
Wireshark code review | 
 | 
| 22:03 | 
[Wireshark-commits] master-1.12 e2793f5: HiSLIP: disable heuristic	dissector by default | 
Wireshark code review | 
 | 
| 22:08 | 
[Wireshark-commits] master 8ce0f12: Resync Debian symbols Fix wrong symbol for proto_tree_add_bitmask_with_flags | 
Wireshark code review | 
 | 
| December 18, 2014 | 
| 00:03 | 
[Wireshark-commits] master 51522b3: Handle "I can't map this for that file format" better. | 
Wireshark code review | 
 | 
| 00:22 | 
[Wireshark-commits] master-1.12 dd17731: Don't use WTAP_ERR_UNSUPPORTED for unwritable records. | 
Wireshark code review | 
 | 
| 00:24 | 
[Wireshark-commits] master-1.10 68e832f: Don't use WTAP_ERR_UNSUPPORTED for unwritable records. | 
Wireshark code review | 
 | 
| 00:32 | 
[Wireshark-commits] master aa27e66: Rename WTAP_ERR_REC_TYPE_UNSUPPORTED to WTAP_ERR_UNWRITABLE_REC_TYPE. | 
Wireshark code review | 
 | 
| 00:41 | 
[Wireshark-commits] master 6011a04: WTAP_ERR_UNWRITABLE_ errors aren't returned by reads or open-for-reading. | 
Wireshark code review | 
 | 
| 04:04 | 
[Wireshark-commits] master 0885d29: Make sure err_info is always set, and print it iff it's non-null. | 
Wireshark code review | 
 | 
| 07:42 | 
[Wireshark-commits] master cb345eb: Use LocatePythonModule to find make-dissector-reg.py in order to make UseMakeDissectorReg.cmake more generally (out-of-source) usable. Add make-dissector-reg.py to the Debian packages. | 
Wireshark code review | 
 | 
| 07:43 | 
[Wireshark-commits] master a73b89b: Use LocatePythonModule to	locate asn2wrs.py | 
Wireshark code review | 
 | 
| 11:02 | 
[Wireshark-commits] master ee4a7f2: DisplayFilter: Check also another fields with the same name | 
Wireshark code review | 
 | 
| 11:02 | 
[Wireshark-commits] master 4a467ff: Bluetooth: BTLE: Add src/dst addresses when they are known | 
Wireshark code review | 
 | 
| 11:03 | 
[Wireshark-commits] master f5cd215: Bluetooth: Add generic	Bluetooth dissector | 
Wireshark code review | 
 | 
| 11:03 | 
[Wireshark-commits] master 361ea82: Add support for multifields in	custom column | 
Wireshark code review | 
 | 
| 11:18 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 11:50 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 12:11 | 
[Wireshark-commits] master e2d7b56: Add new cmake files to the	distribution | 
Wireshark code review | 
 | 
| 16:26 | 
[Wireshark-commits] master f299f73: Add new cmake.in files to the	distribution | 
Wireshark code review | 
 | 
| 17:02 | 
[Wireshark-commits] master 71d13b3: proto.c: Add hint to 'DISSECTOR_ASSERT(hf->bitmask != 0)' to show field name. | 
Wireshark code review | 
 | 
| 18:48 | 
[Wireshark-commits] master-1.12 c4c0edd: mip: Fix Rev Revocation [Ack] Flags dissection bugs. | 
Wireshark code review | 
 | 
| 18:49 | 
[Wireshark-commits] master-1.12 a1a8dc3: mip: fix (what appear to be) bugs in CVSE GRE key extension dissection | 
Wireshark code review | 
 | 
| 19:45 | 
[Wireshark-commits] master 577e6a1: Allow "cba" filter prefix for hf_ fields. Seems like something with "pn" or (abbreviated) Profinet would make more sense (with dissectors to match), but trying to satisfy pre-commit check. | 
Wireshark code review | 
 | 
| 20:08 | 
[Wireshark-commits] master-1.12 5c765dd: openflow: Use (what appear to be the) correct filter names for a few fields. | 
Wireshark code review | 
 | 
| 20:08 | 
[Wireshark-commits] master-1.12 8f432de: eth, mp2t: Rename ei[] filter names duplicating hf[] filter names. | 
Wireshark code review | 
 | 
| December 19, 2014 | 
| 00:56 | 
[Wireshark-commits] master 07eef05: Rename si_code variable to mtp3_si_code to avoid conflicts with NetBSD's si_code #define in sys/siginfo.h | 
Wireshark code review | 
 | 
| 01:06 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 01:08 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 01:16 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 01:17 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Solaris 10 SPARC | 
buildbot-no-reply | 
 | 
| 01:25 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis | 
buildbot-no-reply | 
 | 
| 02:28 | 
[Wireshark-commits] master acbef26: Remove main-menubar-ui.xml	because it's not used. | 
Wireshark code review | 
 | 
| 02:32 | 
[Wireshark-commits] master b000ada: Finish renaming si_code to	mtp3_si_code. | 
Wireshark code review | 
 | 
| 03:51 | 
[Wireshark-commits] master 23987b4: Add a comment to each of these scripts to say that epan/dissectors/README.X11 has instructions for running them. | 
Wireshark code review | 
 | 
| 04:17 | 
[Wireshark-commits] master d3a4d92: Put a colon after the error message and before the field the error is referring to for clarity. | 
Wireshark code review | 
 | 
| 07:12 | 
[Wireshark-commits] master 792c01a: Bluetooth: Remove unused value	strings. | 
Wireshark code review | 
 | 
| 07:59 | 
[Wireshark-commits] master 1f03180: Use new color_dissector_filters.[ch] to refactor (color) conversation generation in GTK menus. | 
Wireshark code review | 
 | 
| 11:58 | 
[Wireshark-commits] master f94eb27: Bring pkg.m4 in from pkgconfig version 0.28 so we can use the PKG_PROG_PKG_CONFIG macro to try searching for pkg-config even when it isn't installed. Without this (and without pkg-config installed) the configure script is broken. With it, it gives a message saying pkg-config isn't found. | 
Wireshark code review | 
 | 
| 11:58 | 
[Wireshark-commits] master c11085a: ISIS: Fix warning: '@return' command used in a comment that is attached to a function returning void [-Wdocumentation] | 
Wireshark code review | 
 | 
| 12:05 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Solaris 10 SPARC | 
buildbot-no-reply | 
 | 
| 17:05 | 
[Wireshark-commits] master 398c2cee: Skip over the new 'switch' field in xproto/src/xinput.xml so we can re-generate the x11 dissector again without the script breaking. | 
Wireshark code review | 
 | 
| 18:00 | 
[Wireshark-commits] master 962fa21: Replace uses of proto_get_frame_protocols with proto_is_frame_protocol when only one protocol is desired. | 
Wireshark code review | 
 | 
| 18:33 | 
[Wireshark-commits] master fbd6caa: Take out parenthesis around faq.txt rule so it works when automake chooses Korn shell instead of Bourne shell. It still works with the Bourne shell in my testing. | 
Wireshark code review | 
 | 
| 20:28 | 
[Wireshark-commits] master 0df4eec: Add parenthesis around some generated code so it compiles. This new code only shows up when the X11 dissector is updated from the latest xcbproto & mesa, which I will commit real soon now (RSN). | 
Wireshark code review | 
 | 
| 21:53 | 
[Wireshark-commits] master d4ff430: Move packet-kerberos.c to the dirty dissectors because it generates warnings (at least on NetBSD), presumably due to our use of -Wc++-compat: | 
Wireshark code review | 
 | 
| 22:06 | 
[Wireshark-commits] master f4ffbbb: Throw some casts at compiler	warnings. | 
Wireshark code review | 
 | 
| 22:08 | 
[Wireshark-commits] master e7d2c8d: Get rid of some accidentally-checked-in debugging stuff. | 
Wireshark code review | 
 | 
| 22:56 | 
[Wireshark-commits] master e2586ec: Provide a floorl() function (which is currently only able to call GCC's __builtin_floorl() function) for systems which don't provide one. | 
Wireshark code review | 
 | 
| 23:03 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 23:12 | 
[Wireshark-commits] master 47dc4e7: Revert "Provide a floorl() function (which is currently only able to call GCC's __builtin_floorl() function) for systems which don't provide one." because I left off the new wsutil/floor.[ch] files | 
Wireshark code review | 
 | 
| 23:12 | 
[Wireshark-commits] master aa0a040: Add missing files from last	commit | 
Wireshark code review | 
 | 
| 23:22 | 
[Wireshark-commits] master dba361b: Add a missing line related to	previous two commits | 
Wireshark code review | 
 | 
| December 20, 2014 | 
| 00:21 | 
[Wireshark-commits] master df1f919: Don't use g_slist_free_full(). | 
Wireshark code review | 
 | 
| 00:28 | 
[Wireshark-commits] master 71fc2f8: Another missing change,	to include floor.h | 
Wireshark code review | 
 | 
| 00:45 | 
[Wireshark-commits] master 2376953: Another missing change | 
Wireshark code review | 
 | 
| 01:32 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 01:57 | 
[Wireshark-commits] master 2f44afe: Use ENCTYPE_NULL in the	krb5_crypto_init() call. | 
Wireshark code review | 
 | 
| 02:02 | 
[Wireshark-commits] master 556f9a5: Include floor.c and floor.h in	the source tarball. | 
Wireshark code review | 
 | 
| 02:30 | 
[Wireshark-commits] master 201a7e7: Change more variables from si_code to mtp3_si_code to avoid conflicts with a #define in a NetBSD header file. | 
Wireshark code review | 
 | 
| 02:54 | 
[Wireshark-commits] master b736896: Handle floorl() the same way we handle other not-on-all-platforms functions. | 
Wireshark code review | 
 | 
| 03:00 | 
[Wireshark-commits] master 1088629: If we don't have GCC,	fall back on using floor(). | 
Wireshark code review | 
 | 
| 03:10 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 03:30 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 03:35 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 03:35 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis | 
buildbot-no-reply | 
 | 
| 03:37 | 
[Wireshark-commits] master b925c35: We assume all versions of MSVC	have floorl(). | 
Wireshark code review | 
 | 
| 03:44 | 
[Wireshark-commits] master b445b3d: Rename wsutil/floor.[ch] to	wsutil/floorl.[ch]. | 
Wireshark code review | 
 | 
| 04:11 | 
[Wireshark-commits] master 07fb8cf: Remove trailing white space. | 
Wireshark code review | 
 | 
| 04:24 | 
[Wireshark-commits] master 1a051af: Include <math.h> to declare	floor(). | 
Wireshark code review | 
 | 
| 04:45 | 
[Wireshark-commits] master caf4cc6: Use AC_SEARCH_LIBS() for math	functions. | 
Wireshark code review | 
 | 
| 05:09 | 
[Wireshark-commits] master 4d3c7b5: Don't bother with	__builtin_floorl(). | 
Wireshark code review | 
 | 
| 05:19 | 
[Wireshark-commits] master 4b8639f: Add a check for floorl(). | 
Wireshark code review | 
 | 
| 08:24 | 
[Wireshark-commits] master a61f6e4: When checking for floorl(),	include math.h. | 
Wireshark code review | 
 | 
| 08:58 | 
[Wireshark-commits] master 79b5bb4: Fix typo. | 
Wireshark code review | 
 | 
| 16:48 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Solaris 10 SPARC | 
buildbot-no-reply | 
 | 
| 16:49 | 
[Wireshark-commits] master 2bb8255: Consolidate RTP stream structs. | 
Wireshark code review | 
 | 
| 17:39 | 
[Wireshark-commits] master 9ba9cd8: Qt: Add a CaptureFile class. | 
Wireshark code review | 
 | 
| 17:47 | 
[Wireshark-commits] master abd90c3: Fix handling of 3-component OS	version numbers. | 
Wireshark code review | 
 | 
| 17:52 | 
[Wireshark-commits] master-1.12 094d469: Fix handling of	3-component OS version numbers. | 
Wireshark code review | 
 | 
| 17:54 | 
[Wireshark-commits] master-1.10 e4b1a6f: Fix handling of	3-component OS version numbers. | 
Wireshark code review | 
 | 
| 17:59 | 
[Wireshark-commits] master 7b2ae71: Fix filter valid/invalid test for multifield custom type | 
Wireshark code review | 
 | 
| 18:04 | 
[Wireshark-commits] master 7d18248: hide the hf_msmms_data item,	not the NULL item | 
Wireshark code review | 
 | 
| 18:04 | 
[Wireshark-commits] master 326e496: no need for if (tree) | 
Wireshark code review | 
 | 
| 18:35 | 
[Wireshark-commits] master 851909d: FCoIB / Infiniband SDP: prevent a crash when 'enable manual settings' is set without filling address field | 
Wireshark code review | 
 | 
| 18:37 | 
[Wireshark-commits] master-1.12 22e8e5f: FCoIB / Infiniband SDP: prevent a crash when 'enable manual settings' is set without filling address field | 
Wireshark code review | 
 | 
| 18:40 | 
[Wireshark-commits] master-1.10 8fee8b7: FCoIB / Infiniband SDP: prevent a crash when 'enable manual settings' is set without filling address field | 
Wireshark code review | 
 | 
| 19:37 | 
[Wireshark-commits] master 2b621e2: 802.11: VHT NDP announcement frame is no correctly decode when there is FCS | 
Wireshark code review | 
 | 
| 19:49 | 
[Wireshark-commits] master 8b24471: Qt: Revert back to an	all-in-one main window. | 
Wireshark code review | 
 | 
| 20:46 | 
[Wireshark-commits] master b4e90bd: Fix filter test for multifield	custom column | 
Wireshark code review | 
 | 
| 22:18 | 
[Wireshark-commits] master d11e94b: Remove debugging code. | 
Wireshark code review | 
 | 
| 22:18 | 
[Wireshark-commits] master ac69a6d: Qt: Use an accordion frame in	the welcome screen. | 
Wireshark code review | 
 | 
| 23:01 | 
[Wireshark-commits] master 210aaf1: Use "" rather than <> for includes; that might fix ABI check failures. | 
Wireshark code review | 
 | 
| December 21, 2014 | 
| 01:57 | 
[Wireshark-commits] master d7fd00d: MIPv6: simplify fixed point	degrees conversion | 
Wireshark code review | 
 | 
| 01:57 | 
[Wireshark-commits] master cadf1a5: Remove profinet_type from	packet_info structure. | 
Wireshark code review | 
 | 
| 04:12 | 
[Wireshark-commits] master 86d1b54: Qt: disable Capture File Properties toolbar icon by default | 
Wireshark code review | 
 | 
| 04:13 | 
[Wireshark-commits] master 8179800: Qt: fix a crash when closing a file while capture file properties window is open | 
Wireshark code review | 
 | 
| 04:14 | 
[Wireshark-commits] master 2b006ad: Have a heur_dissector_list_t be	an opaque handle. | 
Wireshark code review | 
 | 
| 04:52 | 
[Wireshark-commits] master 35571f8: Qt: Fix accordion frame height	calculation. | 
Wireshark code review | 
 | 
| 04:52 | 
[Wireshark-commits] master 14cff7b: Qt: Don't clear the capture	file properties. | 
Wireshark code review | 
 | 
| 05:46 | 
[Wireshark-commits] master b5d7b7a: Cleanup use of #includes in non-generated epan/dissector/*.c | 
Wireshark code review | 
 | 
| 06:48 | 
[Wireshark-commits] master ce211a4: Cleanup use of #includes in a few recently committed dissectors. | 
Wireshark code review | 
 | 
| 07:18 | 
[Wireshark-commits] master 806ebca: packet-PROTOABBREV.c: Update re	#includeusage | 
Wireshark code review | 
 | 
| 07:26 | 
[Wireshark-commits] master a138faf: Clean up some error messages. | 
Wireshark code review | 
 | 
| 07:32 | 
[Wireshark-commits] master deb49cb: Add comments,	change structure member name. | 
Wireshark code review | 
 | 
| 08:54 | 
[Wireshark-commits] master fda12fb: Fix Python 3 compatibility in	LocatePythonModule | 
Wireshark code review | 
 | 
| 09:48 | 
[Wireshark-commits] master da22067: Qt: keep "Copy to clipboard" button active when closing the capture_file_properties_dialog | 
Wireshark code review | 
 | 
| 12:58 | 
[Wireshark-commits] master 6f8de87: Allow "cba" filter prefix for hf_ fields (missed a Profinet file the first time) | 
Wireshark code review | 
 | 
| 15:13 | 
[Wireshark-commits] master cdaa669: Replace ax25_to_str and get_ax25_name with address_to_str. | 
Wireshark code review | 
 | 
| 15:13 | 
[Wireshark-commits] master f002332: Replace ether_to_str with either address_to_str or tvb_ether_to_str. | 
Wireshark code review | 
 | 
| 15:48 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 16:05 | 
[Wireshark-commits] master 9c03655: [Automatic manuf, services and enterprise-numbers update for 2014-12-21] | 
Wireshark code review | 
 | 
| 16:07 | 
[Wireshark-commits] master-1.12 16a11d4: [Automatic manuf, services and enterprise-numbers update for 2014-12-21] | 
Wireshark code review | 
 | 
| 16:09 | 
[Wireshark-commits] master-1.10 c783d41: [Automatic manuf, services and enterprise-numbers update for 2014-12-21] | 
Wireshark code review | 
 | 
| 16:14 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 16:18 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 17:01 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 17:29 | 
[Wireshark-commits] master 9fbede8: no need for if(tree) | 
Wireshark code review | 
 | 
| 18:30 | 
[Wireshark-commits] master bd19532: Do not use packet scope memory outside packet dissectors | 
Wireshark code review | 
 | 
| 18:47 | 
[Wireshark-commits] master bcaf1f4: Qt: Better accordion frame	layout. | 
Wireshark code review | 
 | 
| 18:52 | 
[Wireshark-commits] master ccf0573: Qt: rename SummaryDialog class to CaptureFilePropertiesDialog | 
Wireshark code review | 
 | 
| 20:47 | 
[Wireshark-commits] master 9407160: Do not use packet scoped memory	in GUI | 
Wireshark code review | 
 | 
| 21:07 | 
[Wireshark-commits] master c96858b: Use the "netbios" heuristic dissector list elsewhere. | 
Wireshark code review | 
 | 
| 21:45 | 
[Wireshark-commits] master 5d30a3c: Define helper macros before	they're used. | 
Wireshark code review | 
 | 
| 22:10 | 
[Wireshark-commits] master 0be413e: Move another helper macro. | 
Wireshark code review | 
 | 
| 23:17 | 
[Wireshark-commits] master 48419fc: Improve the message for "this field doesn't have the right type" assertions. | 
Wireshark code review | 
 | 
| 23:36 | 
[Wireshark-commits] master c30aa11: Register the ORFEntry IP	address as an IPv4 address. | 
Wireshark code review | 
 | 
| December 22, 2014 | 
| 00:09 | 
[Wireshark-commits] master 147ca45: Improve the message for "this field has an integral type" assertions. | 
Wireshark code review | 
 | 
| 00:16 | 
[Wireshark-commits] master 8228bcf: Wrong array. | 
Wireshark code review | 
 | 
| 00:42 | 
[Wireshark-commits] master 8076f29: Qt: Fix status bar signal. | 
Wireshark code review | 
 | 
| 02:31 | 
[Wireshark-commits] master a5a2565: Removing ptp.v2.an.fcs as this erroneously refers to the Ethernet FCS which is properly handled by the Ethernet dissector. | 
Wireshark code review | 
 | 
| 02:53 | 
[Wireshark-commits] master-1.12 f5cde82: Removing ptp.v2.an.fcs as this erroneously refers to the Ethernet FCS which is properly handled by the Ethernet dissector. | 
Wireshark code review | 
 | 
| 02:59 | 
[Wireshark-commits] master 859360a: BGP : Update BGP-LS Attribute +	Display NEXT_HOP | 
Wireshark code review | 
 | 
| 03:33 | 
[Wireshark-commits] master 4cb19d4: Use the messageLength field to indicate the message length. | 
Wireshark code review | 
 | 
| 04:07 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 04:36 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 04:59 | 
[Wireshark-commits] master 94eeaf1: print.c: clean up #includes | 
Wireshark code review | 
 | 
| 04:59 | 
[Wireshark-commits] master 971d4e4: stats_tree: g_sprintf()-->g_snprintf(); cleanup #includes. | 
Wireshark code review | 
 | 
| 05:00 | 
[Wireshark-commits] master 998a847: plugins: Cleanup #includes | 
Wireshark code review | 
 | 
| 06:43 | 
[Wireshark-commits] master 7b721a1: Squelch a compiler warning. | 
Wireshark code review | 
 | 
| 06:57 | 
[Wireshark-commits] master 37940ee: Fix AARP AppleTalk address	parsing | 
Wireshark code review | 
 | 
| 07:24 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 07:39 | 
[Wireshark-commits] master 9b3f9b7: Fix The left operand of '!=' is a garbage value issue found by Clang Analyzer | 
Wireshark code review | 
 | 
| 08:17 | 
[Wireshark-commits] master 67cbafa: remove unnecessary integer	overflow checks | 
Wireshark code review | 
 | 
| 15:22 | 
[Wireshark-commits] master 3cb816c: PTP: Fix ptp_tree may be used uninitialized in this function [-Werror=maybe-uninitialized] | 
Wireshark code review | 
 | 
| 15:23 | 
[Wireshark-commits] master 414701d: ANSI_MAP: Fix unused function	(by add to .OMIT list) | 
Wireshark code review | 
 | 
| 15:23 | 
[Wireshark-commits] master f8720a6: ANSI MAP: Remove from Dirty	ASN1 list | 
Wireshark code review | 
 | 
| 15:23 | 
[Wireshark-commits] master ed2df3b: fix warning: parameter 'list' not found in the function declaration [-Wdocumentation] | 
Wireshark code review | 
 | 
| 15:24 | 
[Wireshark-commits] master 5248c0d: Fix unknown command tag name [-Wdocumentation-unknown-command] | 
Wireshark code review | 
 | 
| 16:17 | 
[Wireshark-commits] master 352bd87: packet-couchbase.c: remove field which does not exists | 
Wireshark code review | 
 | 
| 17:11 | 
[Wireshark-commits] master 30c3d39: Revert "Move packet-kerberos.c to the dirty dissectors because it generates warnings (at least on NetBSD), presumably due to our use of -Wc++-compat:" | 
Wireshark code review | 
 | 
| 18:12 | 
[Wireshark-commits] master 5cdad9f: Qt: Add methods to CaptureFile and WiresharkApplication. | 
Wireshark code review | 
 | 
| 19:43 | 
[Wireshark-commits] master b018128: Cast a parameter in the kerberos dissector so it compiles without warnings on NetBSD. | 
Wireshark code review | 
 | 
| 21:03 | 
[Wireshark-commits] master 596669f: First batch of unincludes. Last	attempt... | 
Wireshark code review | 
 | 
| 21:11 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 21:11 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 21:24 | 
[Wireshark-commits] master d541774: Include <math.h> or <stdlib.h> as necessary to declare functions. | 
Wireshark code review | 
 | 
| 21:26 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 21:52 | 
[Wireshark-commits] master 59b4ab5: Include <math.h> or <stdlib.h> as necessary to declare functions. | 
Wireshark code review | 
 | 
| December 23, 2014 | 
| 00:22 | 
[Wireshark-commits] master 3d62d2c: Move popcount() to an optionally built part of wsutil for systems that provide their own popcount(). | 
Wireshark code review | 
 | 
| 00:23 | 
[Wireshark-commits] master ae6df38: packet-dtls.c still needs	conversation.h | 
Wireshark code review | 
 | 
| 00:34 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 00:41 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| 00:45 | 
[Wireshark-commits] master 4009231: Try to fix Windows build for popcount() unresolved external symbol | 
Wireshark code review | 
 | 
| 00:48 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis | 
buildbot-no-reply | 
 | 
| 00:53 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 00:54 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 01:07 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 05:04 | 
[Wireshark-commits] master 1b37f4c: Cmake: check for popcount, and build it from wsutil/popcount.c if missing. | 
Wireshark code review | 
 | 
| 05:38 | 
[Wireshark-commits] master 17582d3: asn1/Makefile.nmake: packet-c1222.c not autogenerated using Windows nmake | 
Wireshark code review | 
 | 
| 05:39 | 
[Wireshark-commits] master dd859ea: asn1 generated dissectors:	cleanup #include usage | 
Wireshark code review | 
 | 
| 05:42 | 
[Wireshark-commits] master-1.12 41b59f2: asn1/Makefile.nmake: packet-c1222.c not autogenerated using Windows nmake | 
Wireshark code review | 
 | 
| 05:49 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 05:51 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 05:53 | 
[Wireshark-commits] master-1.10 8827179: asn1/Makefile.nmake: packet-c1222.c not autogenerated using Windows nmake | 
Wireshark code review | 
 | 
| 06:03 | 
[Wireshark-commits] master 3d05935: kerberos: Re-add needed	#include <stdio.h> | 
Wireshark code review | 
 | 
| 06:06 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 07:08 | 
[Wireshark-commits] master b5ff13a: UseLemon (CMake): Fix indent	(use space) | 
Wireshark code review | 
 | 
| 07:09 | 
[Wireshark-commits] master 7208591: CMake (epan/CMakeList.txt): fix	indent (use tabs) | 
Wireshark code review | 
 | 
| 07:09 | 
[Wireshark-commits] master c3d7080: Makefile (epan/dissectors): fix	indent (use tabs) | 
Wireshark code review | 
 | 
| 07:27 | 
[Wireshark-commits] master cd55821: test suite: fix indent (use	tabs) and add modelines | 
Wireshark code review | 
 | 
| 07:30 | 
[Wireshark-commits] master f1562e2: NDPS: Missing break in switch	(CID 281286) | 
Wireshark code review | 
 | 
| 11:45 | 
[Wireshark-commits] master f103865: RSVP: RECORD_ROUTE IPv4 Subobject Flags field incorrect decoding | 
Wireshark code review | 
 | 
| 11:49 | 
[Wireshark-commits] master 4df2306: ISNS: Missing break in switch	(CID 280460) | 
Wireshark code review | 
 | 
| 11:51 | 
[Wireshark-commits] master 216cc12: NASDAQ ITCH: Missing break in	switch (CID 280465) | 
Wireshark code review | 
 | 
| 11:52 | 
[Wireshark-commits] master b87b3db: NetScaler Trace: Missing break in switch (CID 281457, 727776 & 1021060) | 
Wireshark code review | 
 | 
| 11:54 | 
[Wireshark-commits] master 0e78f7e: RTPS: Missing break in switch	(CID 996922) | 
Wireshark code review | 
 | 
| 12:22 | 
[Wireshark-commits] master 48db254: Deleting unneccessary #includes from dissectors. Second batch (packet-eth.c -> packet-icmpv6.d). | 
Wireshark code review | 
 | 
| 12:31 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 12:31 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 12:39 | 
[Wireshark-commits] master 28e24ad: epan/llcsaps.h was needed,	so restore include | 
Wireshark code review | 
 | 
| 12:57 | 
[Wireshark-commits] master 35949f3: Restore stdlib.h (should not have been deleted - mispelt in script) | 
Wireshark code review | 
 | 
| 13:02 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 13:24 | 
[Wireshark-commits] master-1.12 b9db01d: RSVP: RECORD_ROUTE IPv4 Subobject Flags field incorrect decoding | 
Wireshark code review | 
 | 
| 13:25 | 
[Wireshark-commits] master-1.10 677d667: RSVP: RECORD_ROUTE IPv4 Subobject Flags field incorrect decoding | 
Wireshark code review | 
 | 
| 13:55 | 
[Wireshark-commits] master 91cc343: Qt (emitAppSignal): Missing break in switch (CID 1159204) | 
Wireshark code review | 
 | 
| 13:58 | 
[Wireshark-commits] master c670adc: DOCSIS: missing break in switch (CID 280485 & 280486) | 
Wireshark code review | 
 | 
| 13:59 | 
[Wireshark-commits] master 377555e: [column utils] fix warning: unknown command tag name [-Wdocumentation-unknown-command] | 
Wireshark code review | 
 | 
| 14:44 | 
[Wireshark-commits] master 86ed26f: Deleting unnecessary #includes from dissectors. Third batch (packet-icmpv6.c -> packet-mac-lte.c). | 
Wireshark code review | 
 | 
| 14:53 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 14:54 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 15:03 | 
[Wireshark-commits] master 78edcff: Adding back epan/prefs.h to try	to fix build | 
Wireshark code review | 
 | 
| 15:16 | 
[Wireshark-commits] master 9d7709e: Restore prefs.h for ipv6 too | 
Wireshark code review | 
 | 
| 17:16 | 
[Wireshark-commits] master 7e8a4b0: Deleting unnecessary #includes from dissectors. Fourth batch (packet-mac-lte.c -> packet-rtp.c). | 
Wireshark code review | 
 | 
| 19:11 | 
[Wireshark-commits] master 0b6adfc: Add .mailmap: fix duplicate/wrong e-mail or name in commit log | 
Wireshark code review | 
 | 
| 20:44 | 
[Wireshark-commits] master 7d87adf: packet-reload needs	conversation.h still | 
Wireshark code review | 
 | 
| 22:26 | 
[Wireshark-commits] master afbdf10: Change version info string "without locale" to "with default locale" so it doesn't sound as though something is missing. | 
Wireshark code review | 
 | 
| 23:13 | 
[Wireshark-commits] master bcbfe79: Update README.bsd, mainly to put just the primary dependencies that Wireshark needs and remove the others since GTK2/GTK3/Qt require different things and those may change over time so let those programs tell the user what they need. | 
Wireshark code review | 
 | 
| December 24, 2014 | 
| 00:31 | 
[Wireshark-commits] master 37773b7: Insert URLs for finding Wireshark's dependencies in README.bsd | 
Wireshark code review | 
 | 
| 00:42 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 13:16 | 
[Wireshark-commits] master a0e9fe5: TDS: Missing break in switch	(CID 280475 & 281377) | 
Wireshark code review | 
 | 
| 14:57 | 
[Wireshark-commits] master 29d02a3: canopen: Verbosity for INFO	column | 
Wireshark code review | 
 | 
| 16:41 | 
[Wireshark-commits] master 45daef6: Put a C comment in dummy.cpp so the user knows where dummy.cpp came from if it is ever created during the build process. | 
Wireshark code review | 
 | 
| 16:51 | 
[Wireshark-commits] master 2d8ec49: Move twelve show_version() functions from the varoius programs and Wireshark UI files into a single one in wsutil. | 
Wireshark code review | 
 | 
| 17:02 | 
[Wireshark-commits] master 4876016: Qt (KeyPressEvent): Missing break in switch (CID 1159205, 1159206, 1159208, 1159209) | 
Wireshark code review | 
 | 
| 17:03 | 
[Wireshark-commits] master bfa9ddf: Qt (pref.gui_layout_type): Missing break in switch (CID 1159202 & 1159203) | 
Wireshark code review | 
 | 
| 17:39 | 
[Wireshark-commits] master 04a1f33: test suite: (Minor) fix some	double space | 
Wireshark code review | 
 | 
| 17:42 | 
[Wireshark-commits] master 762bb18: RSVP: Conversations / Endpoint: wrong filter when select a RSVP conversations / endpoint (INVALID == a.x.y.z ...) | 
Wireshark code review | 
 | 
| 17:44 | 
[Wireshark-commits] master d3888ff: RSVP: fix display of unknown	Juniper Attribut | 
Wireshark code review | 
 | 
| 18:59 | 
[Wireshark-commits] master e03ffe2: Replace fc_to_str with address_to_str or tvb_fc_to_str. | 
Wireshark code review | 
 | 
| 21:27 | 
[Wireshark-commits] master 4b6141b: GIOP dissector doesn't handle	two packets in a row | 
Wireshark code review | 
 | 
| 23:00 | 
[Wireshark-commits] master 1bbe6e6: TCP: fix indent and reorder	Multipath TCP | 
Wireshark code review | 
 | 
| 23:02 | 
[Wireshark-commits] master 59bdad3: packet-git.c says it was copied from packet-pop, but that doesn't mean packet-git is for "RFC 1939" (POP3), so remove that comment. | 
Wireshark code review | 
 | 
| 23:03 | 
[Wireshark-commits] master 499a7d0: TCP: TCP Fast Open Cookie is	now standardised | 
Wireshark code review | 
 | 
| 23:38 | 
[Wireshark-commits] master c01bad2: Add -msse4.2 to the compiler flags if it's supported. | 
Wireshark code review | 
 | 
| 23:55 | 
[Wireshark-commits] master 153c63d: Don't use extra variables for ws_mempbrk_sse42.c and popcount.c | 
Wireshark code review | 
 | 
| December 25, 2014 | 
| 00:14 | 
[Wireshark-commits] master 2233ef5: Include some files based on whether the functions they define are present. | 
Wireshark code review | 
 | 
| 00:28 | 
[Wireshark-commits] master b6f70ed: NBAP: fix ddi missed for non first macdflow_id in E-DCH channel | 
Wireshark code review | 
 | 
| 01:11 | 
[Wireshark-commits] master 20503c7: Check for getopt_long(),	not getopt(). | 
Wireshark code review | 
 | 
| 08:57 | 
[Wireshark-commits] master-1.12 144655e: Include wsgetopt.c based on whether getopt() is present. | 
Wireshark code review | 
 | 
| 09:07 | 
[Wireshark-commits] master-1.12 a8f5bbe: Check for getopt_long(),	not getopt(). | 
Wireshark code review | 
 | 
| 09:14 | 
[Wireshark-commits] master de8c81c: Use getopt_long(). | 
Wireshark code review | 
 | 
| 09:15 | 
[Wireshark-commits] master-1.12 84db788: Use getopt_long(). | 
Wireshark code review | 
 | 
| 10:24 | 
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Ubuntu	14.04 x64 | 
buildbot-no-reply | 
 | 
| 15:14 | 
[Wireshark-commits] master 2391a43: Bug 10233 - Wireshark crashes if Lua heuristic dissector returns true | 
Wireshark code review | 
 | 
| 15:14 | 
[Wireshark-commits] master ceeeea0: Lua accessor for Protocol field	type gets wrong data | 
Wireshark code review | 
 | 
| 21:03 | 
[Wireshark-commits] master e08eba9: Only include <wsutil/os_version_info.h> if we need it. | 
Wireshark code review | 
 | 
| 21:10 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 21:11 | 
[Wireshark-commits] master 9c7c72d: VoIP Calls: Missing break in	switch (CID 1155515) | 
Wireshark code review | 
 | 
| 22:43 | 
[Wireshark-commits] master adb81f3: Deleting unnecessary #includes from dissectors. Fifth batch (packet-rtp.c -> end). | 
Wireshark code review | 
 | 
| December 26, 2014 | 
| 07:26 | 
[Wireshark-commits] master f2224bc: rpc: Prevent "malformed" for RPC 'NULL proc' packets. | 
Wireshark code review | 
 | 
| 08:22 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 18:58 | 
[Wireshark-commits] master a442a1c: WCCP: initialize address table	to 0 | 
Wireshark code review | 
 | 
| 19:35 | 
[Wireshark-commits] master-1.12 dea8d02: wccp: use pinfo-scope	memory for addresses | 
Wireshark code review | 
 | 
| 19:35 | 
[Wireshark-commits] master-1.12 adce5fa: WCCP: initialize address	table to 0 | 
Wireshark code review | 
 | 
| 20:41 | 
[Wireshark-commits] master 4cf6583: Remove proto_tree_add_text from	ZigBee dissectors. | 
Wireshark code review | 
 | 
| 20:55 | 
[Wireshark-commits] master b68fb9b: Fix some dissectors doing termio (fprintf(stderr, ..), g_warning()). | 
Wireshark code review | 
 | 
| 21:17 | 
[Wireshark-commits] master 3d3f973: Replace ip_to_str with [ep_]address_to_str and tvb_ip_to_str. | 
Wireshark code review | 
 | 
| 21:44 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 21:49 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 21:50 | 
[Wireshark-commits] master ea6a578: Try to fix compilation broken	by g3d3f973 | 
Wireshark code review | 
 | 
| 21:52 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 22:18 | 
[Wireshark-commits] master a2beef9: Fix assertion when applying	conversation color | 
Wireshark code review | 
 | 
| 22:37 | 
[Wireshark-commits] master 2c6d2bb: UDP: fix 'Follow Stream' button from conversations tab | 
Wireshark code review | 
 | 
| 22:39 | 
[Wireshark-commits] master c2c9a09: Use getopt_long() for the first pass through the argument list. | 
Wireshark code review | 
 | 
| 22:43 | 
[Wireshark-commits] master eff91ed: Fix building of color	conversation filter | 
Wireshark code review | 
 | 
| December 27, 2014 | 
| 02:11 | 
[Wireshark-commits] master-1.12 cc1d20f: Use getopt_long() for the first pass through the argument list. | 
Wireshark code review | 
 | 
| 02:21 | 
[Wireshark-commits] master 0a0ce2b: Check for optreset in CMake as	well. | 
Wireshark code review | 
 | 
| 02:22 | 
[Wireshark-commits] master-1.12 40903e8: Check for optreset in	CMake as well. | 
Wireshark code review | 
 | 
| 02:24 | 
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 7	x64 | 
buildbot-no-reply | 
 | 
| 02:27 | 
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows	8.1 x86 | 
buildbot-no-reply | 
 | 
| 02:37 | 
[Wireshark-commits] master-1.12 4ed34c5: Add an (empty) list of	long options to tfshark. | 
Wireshark code review | 
 | 
| 02:47 | 
[Wireshark-commits] master 4536271: Don't use a leading - in getopt_long() option strings. | 
Wireshark code review | 
 | 
| 02:49 | 
[Wireshark-commits] master-1.12 cdc440a: Don't use a leading - in getopt_long() option strings. | 
Wireshark code review | 
 | 
| 10:44 | 
[Wireshark-commits] master ca6f849: IP: try to fix OSX 10.5 x86	compilation | 
Wireshark code review | 
 | 
| 10:58 | 
[Wireshark-commits] master c04aebd: Declare cur_rt in the narrowest	possible scope. | 
Wireshark code review | 
 | 
| 14:46 | 
[Wireshark-commits] master a1c6341: Eliminate proto_tree_add_text	from packet-srvloc.c | 
Wireshark code review | 
 | 
| 15:35 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 15:36 | 
[Wireshark-commits] master 0ea310d: SRVLOC: fix some fields registration (regression introduced in ga1c6341) | 
Wireshark code review | 
 | 
| 15:47 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 16:00 | 
[Wireshark-commits] master 1ae0c4a: Fix -z statistics command line	parsing | 
Wireshark code review | 
 | 
| 17:03 | 
[Wireshark-commits] master 25c7e0d: OpenFlow: fix dissection of async_config_prop structure | 
Wireshark code review | 
 | 
| 17:04 | 
[Wireshark-commits] master-1.12 dccb92d: OpenFlow: fix dissection of async_config_prop structure | 
Wireshark code review | 
 | 
| 19:40 | 
[Wireshark-commits] master ea6f5a3: Zebra dissector highlights wrong byte for version and is missing some fields | 
Wireshark code review | 
 | 
| 20:56 | 
[Wireshark-commits] master 51e5869: Get rid of packet data members	of header structures. | 
Wireshark code review | 
 | 
| 23:04 | 
[Wireshark-commits] master 73af2d6: We require pkg-config to check for, for example, GLib. | 
Wireshark code review | 
 | 
| 23:17 | 
[Wireshark-commits] master d094fca: Check for pkg-config. | 
Wireshark code review | 
 | 
| December 28, 2014 | 
| 00:02 | 
[Wireshark-commits] master 63ebe91: Removed duplicated #include	lines | 
Wireshark code review | 
 | 
| 10:19 | 
[Wireshark-commits] master 120628e: Don't check the same character twice in a row, check it and the next character. | 
Wireshark code review | 
 | 
| 10:20 | 
[Wireshark-commits] master-1.12 30fe8ed: Don't check the same character twice in a row, check it and the next character. | 
Wireshark code review | 
 | 
| 10:20 | 
[Wireshark-commits] master-1.10 0966d7d: Don't check the same character twice in a row, check it and the next character. | 
Wireshark code review | 
 | 
| 10:29 | 
[Wireshark-commits] master 9fce4dd: If we can't open the GeoIP database, close and unlink the map file. | 
Wireshark code review | 
 | 
| 11:13 | 
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows	8.1 x86 | 
buildbot-no-reply | 
 | 
| 14:09 | 
[Wireshark-commits] master 1d598bb: Replace ip6_to_str and ip6_guint8_to_str with address_to_str and tvb_ip_to_str. | 
Wireshark code review | 
 | 
| 16:05 | 
[Wireshark-commits] master 1b6da9e: [Automatic manuf, services and enterprise-numbers update for 2014-12-28] | 
Wireshark code review | 
 | 
| 16:07 | 
[Wireshark-commits] master-1.12 661dc9d: [Automatic manuf, services and enterprise-numbers update for 2014-12-28] | 
Wireshark code review | 
 | 
| 16:10 | 
[Wireshark-commits] master-1.10 1266276: [Automatic manuf, services and enterprise-numbers update for 2014-12-28] | 
Wireshark code review | 
 | 
| 17:08 | 
[Wireshark-commits] master 15a9f5d: Move Windows build to be VS2013 based using the Community Edition Drop references to long obsolete compilers. Added Chocolatey installer instructions for some packages. | 
Wireshark code review | 
 | 
| 17:46 | 
[Wireshark-commits] master f3fd6b5: The symbol rate in the Cable Delivery System Descriptor is in Mega-Symbols/s | 
Wireshark code review | 
 | 
| 18:17 | 
[Wireshark-commits] master 8965e90: Qt Follow window: keep data representation when switching between streams | 
Wireshark code review | 
 | 
| 20:05 | 
[Wireshark-commits] master 71c02b2: Create FT_FCWWN field type. | 
Wireshark code review | 
 | 
| 21:00 | 
[Wireshark-commits] master 5e16157: p_mul: Added checksum from ACP	142(A) | 
Wireshark code review | 
 | 
| 21:26 | 
[Wireshark-commits] master 016769d: Expose	dissector_add_for_decode_as() to Lua | 
Wireshark code review | 
 | 
| 23:34 | 
[Wireshark-commits] master e3efb80: Deleting unnecessary #includes	from wsutil. | 
Wireshark code review | 
 | 
| 23:41 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 23:41 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 23:47 | 
[Wireshark-commits] master 5efc18e: Restore string.h as OS X misses	it for strlen() | 
Wireshark code review | 
 | 
| 23:51 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 23:57 | 
[Wireshark-commits] master f215575: Add a couple of more needed	includes | 
Wireshark code review | 
 | 
| December 29, 2014 | 
| 00:09 | 
[Wireshark-commits] master 518e48d: Add back string.h | 
Wireshark code review | 
 | 
| 00:12 | 
[Wireshark-commits] master 30edb91: Add string.h back to rc4.c | 
Wireshark code review | 
 | 
| 00:18 | 
[Wireshark-commits] master 8ae669c: Restore string.h to md4.c | 
Wireshark code review | 
 | 
| 00:35 | 
[Wireshark-commits] master 85781bb: Add back string.h to sha1.c and	sober128.c | 
Wireshark code review | 
 | 
| 01:02 | 
[Wireshark-commits] master-1.12 c996e1f: Spice dissector - bugfix	offset computation. | 
Wireshark code review | 
 | 
| 01:05 | 
[Wireshark-commits] master c1d9d93: Restore string.h to os_version.c | 
Wireshark code review | 
 | 
| 01:42 | 
[Wireshark-commits] master e8ec11f: Qt: Add a WiresharkDialog	convenience class. | 
Wireshark code review | 
 | 
| 11:33 | 
[Wireshark-commits] master 5f2b998: Minor doc updates,	added Windows debugging info | 
Wireshark code review | 
 | 
| 13:57 | 
[Wireshark-commits] master 5b088af: Eliminate proto_tree_add_text	from packet-spice.c | 
Wireshark code review | 
 | 
| 16:19 | 
[Wireshark-commits] master 10bfe2c: dcerpc: Replace g_warning() by expert...() (dissectors shouldn't do termio). | 
Wireshark code review | 
 | 
| 16:33 | 
[Wireshark-commits] master 211789c: OpenFlow: Capatilize O and F of OpenFlow (when use Decode as) | 
Wireshark code review | 
 | 
| 16:34 | 
[Wireshark-commits] master fce9da3: Zebra: Fix some indent typo | 
Wireshark code review | 
 | 
| 16:35 | 
[Wireshark-commits] master 90ba166: capture_file.h (Qt): missing ] | 
Wireshark code review | 
 | 
| 16:36 | 
[Wireshark-commits] master ea08072: Wireshark Dialog (Qt): Add	Modelines info | 
Wireshark code review | 
 | 
| 18:10 | 
[Wireshark-commits] master 72dedab: rtsp: Replace g_warning() by expert...() (dissectors shouldn't do termio). | 
Wireshark code review | 
 | 
| 18:18 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 18:20 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 18:30 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 18:56 | 
[Wireshark-commits] master 7ca5ad9: rtsp: Fix compiler 'Shadow'	warning ... | 
Wireshark code review | 
 | 
| 19:25 | 
[Wireshark-commits] master 71fe134: rtsp: Fix (what I think may be)	a minor bug. | 
Wireshark code review | 
 | 
| 19:38 | 
[Wireshark-commits] master-1.12 d041bb1: rtsp: Fix what (appears to be)/(may be) a minor bug. | 
Wireshark code review | 
 | 
| 19:48 | 
[Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.7	x64 | 
buildbot-no-reply | 
 | 
| 20:12 | 
[Wireshark-commits] master 621dbdd: Windows build improvements: | 
Wireshark code review | 
 | 
| 20:14 | 
[Wireshark-commits] master 0fb4cdb: Wimaxasncp: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang | 
Wireshark code review | 
 | 
| 20:53 | 
[Wireshark-commits] master 0905202: TN5250: Missing break in switch	(CID 280477) | 
Wireshark code review | 
 | 
| 22:17 | 
[Wireshark-commits] master 0d414e5: Add ability to follow UDP	stream by index | 
Wireshark code review | 
 | 
| 23:10 | 
[Wireshark-commits] master ed58d88: Remove some proto_tree_add_text outside the dissector directory. | 
Wireshark code review | 
 | 
| December 30, 2014 | 
| 02:59 | 
[Wireshark-commits] master b6ff338: Tabs are not necessarily set	every 4 spaces. | 
Wireshark code review | 
 | 
| 03:18 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 03:34 | 
[Wireshark-commits] master 4556498: Qt: Convert more dialogs to	WiresharkDialog. | 
Wireshark code review | 
 | 
| 13:01 | 
[Wireshark-commits] master e0d268b: stats_tree: Make sure some structs are fully initialized. | 
Wireshark code review | 
 | 
| 13:05 | 
[Wireshark-commits] master-1.12 474728d: Bug 10233 - Wireshark crashes if Lua heuristic dissector returns true | 
Wireshark code review | 
 | 
| 13:06 | 
[Wireshark-commits] master-1.12 1c14653: Lua accessor for Protocol field type gets wrong data | 
Wireshark code review | 
 | 
| 13:06 | 
[Wireshark-commits] master-1.10 62a149c: Lua accessor for Protocol field type gets wrong data | 
Wireshark code review | 
 | 
| 15:35 | 
[Wireshark-commits] master d45fe5c: .mailmap: Add Hadriel Kaplan | 
Wireshark code review | 
 | 
| 15:52 | 
[Wireshark-commits] master 1ee4369: no need for if(tree) | 
Wireshark code review | 
 | 
| 16:37 | 
[Wireshark-commits] master 8629aa2: Qt: Continue using the new	window title format. | 
Wireshark code review | 
 | 
| 17:03 | 
[Wireshark-commits] master e05e8f8: skip the payload if it's empty | 
Wireshark code review | 
 | 
| 17:04 | 
[Wireshark-commits] master 246f727: use packet-scoped memory for	the unmasked data tvb | 
Wireshark code review | 
 | 
| 17:04 | 
[Wireshark-commits] master f3f736c: clean up the part where dissect_websocket() is called recursively | 
Wireshark code review | 
 | 
| 17:18 | 
[Wireshark-commits] master 935c8bf: Websocket: use pinfo pool and not packet one for the unmasked data tvb | 
Wireshark code review | 
 | 
| 18:27 | 
[Wireshark-commits] master bc7a9e5: Fix IPv6/IPX statistics	generation | 
Wireshark code review | 
 | 
| 18:34 | 
[Wireshark-commits] master 97f5f39: free the temporary buffers allocated by gnutls_x509_privkey_export_rsa_raw() | 
Wireshark code review | 
 | 
| 19:29 | 
[Wireshark-commits] master-1.12 aaaa98e: qt: fix use-after-free	pattern | 
Wireshark code review | 
 | 
| 20:44 | 
[Wireshark-commits] master 3b57861: Qt: More WiresharkDialog	conversions. | 
Wireshark code review | 
 | 
| 21:20 | 
[Wireshark-commits] master dcbebe0: Test suite: Start testing our output for valid UTF-8. | 
Wireshark code review | 
 | 
| 21:20 | 
[Wireshark-commits] master-1.12 dfa49cd: Test suite: Start testing our output for valid UTF-8. | 
Wireshark code review | 
 | 
| 21:39 | 
[Wireshark-commits] master-1.10 db548c7: Test suite: Start testing our output for valid UTF-8. | 
Wireshark code review | 
 | 
| 22:20 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 22:20 | 
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Ubuntu	14.04 x64 | 
buildbot-no-reply | 
 | 
| 23:22 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 7 x64 | 
buildbot-no-reply | 
 | 
| December 31, 2014 | 
| 00:28 | 
[Wireshark-commits] master 4eeb440: Remove proto_tree_add_text from packet-dcerpc-pn-io.c | 
Wireshark code review | 
 | 
| 03:41 | 
[Wireshark-commits] master c1f3047: Move the version_info.c stuff to wsutil/ws_version_info.c. | 
Wireshark code review | 
 | 
| 03:54 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 04:24 | 
[Wireshark-commits] master 84110d2: tshark: endpoints statistics are not supported for now, do not list them in -z | 
Wireshark code review | 
 | 
| 06:12 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Windows 8.1 x86 | 
buildbot-no-reply | 
 | 
| 06:29 | 
[Wireshark-commits] master 27be466: Do the full string in get_{compiled, runtime}_version_info(). | 
Wireshark code review | 
 | 
| 06:34 | 
[Wireshark-commits] master 0bf38f7: Lua: getting fieldinfo.value for FT_NONE causes assert | 
Wireshark code review | 
 | 
| 07:00 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.6 x64 | 
buildbot-no-reply | 
 | 
| 07:03 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	OSX 10.5 x86 | 
buildbot-no-reply | 
 | 
| 07:07 | 
[Wireshark-commits] master 938b6a7: Wrong function name. | 
Wireshark code review | 
 | 
| 07:10 | 
[Wireshark-commits] master 64dd98e: No version_info.c any more. | 
Wireshark code review | 
 | 
| 08:03 | 
[Wireshark-commits] master a3d946c: BGP : Simple typo fix for BGP	Attribute | 
Wireshark code review | 
 | 
| 08:50 | 
[Wireshark-commits] master 8f75a2e: And, again,	no more version_info.c. | 
Wireshark code review | 
 | 
| 09:03 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Clang Code Analysis | 
buildbot-no-reply | 
 | 
| 09:19 | 
[Wireshark-commits] master 914dc6c: E.164: display country_code as	decimal not hex | 
Wireshark code review | 
 | 
| 10:23 | 
[Wireshark-commits] master 37efc4a: We do stuff with signals only	on UN*Xes. | 
Wireshark code review | 
 | 
| 12:51 | 
[Wireshark-commits] master 22701ad: DNS: ensure that suffix_addr structure is always initialized | 
Wireshark code review | 
 | 
| 14:19 | 
[Wireshark-commits] master 3865bca: Update libwsutil symbols | 
Wireshark code review | 
 | 
| 14:35 | 
[Wireshark-commits] master c34c2a6: Fix conversations filtering | 
Wireshark code review | 
 | 
| 14:58 | 
[Wireshark-commits] master 60d7413: prefs: fix typo | 
Wireshark code review | 
 | 
| 14:59 | 
[Wireshark-commits] master 7c93e81: Column utils: Missing varargs init or cleanup (CID 1212122) | 
Wireshark code review | 
 | 
| 15:00 | 
[Wireshark-commits] master aeb10b9: mount: fix Copy-paste error	(CID 1224605) | 
Wireshark code review | 
 | 
| 15:01 | 
[Wireshark-commits] master 0f6f2bd: jxta: fix Copy-paste error (CID	1158599 & 1158600) | 
Wireshark code review | 
 | 
| 15:17 | 
[Wireshark-commits] master 784b39c: GTPv2: fix typo in Anders	e-mail Address | 
Wireshark code review | 
 | 
| 15:17 | 
[Wireshark-commits] master beb50e6: DHCPv6: fix Nesting level does not match indendation (CID 1159219) | 
Wireshark code review | 
 | 
| 15:21 | 
[Wireshark-commits] master 493e413: SCTP: fix Nesting level does not match indendation (CID 1159213 & 1159215 ) | 
Wireshark code review | 
 | 
| 15:35 | 
[Wireshark-commits] master 9e7d69f: checkAPIs.pl: Error/warnings	output goes to STDERR | 
Wireshark code review | 
 | 
| 15:49 | 
[Wireshark-commits] master a1732dc: GTK: fix 'Limit to display filter' functionality in Conversations/Endpoints windows | 
Wireshark code review | 
 | 
| 15:50 | 
[Wireshark-commits] master 1121288: GTP: fix Copy-paste error (CID	1158594 & 1158595) | 
Wireshark code review | 
 | 
| 16:01 | 
[Wireshark-commits] master f7b6dcc: Lua: allow a Dissector object to be passed in for register_heuristic | 
Wireshark code review | 
 | 
| 16:11 | 
[Wireshark-commits] master b0e6fbf: umts_fp: Replace se_new0(...) by wmem_new0(wmem_file_scope(), ...) | 
Wireshark code review | 
 | 
| 17:11 | 
[Wireshark-commits] master 24c076f: pcapng (wiretap): fix Copy-paste error (CID 1158591 & 1158592) | 
Wireshark code review | 
 | 
| 17:12 | 
[Wireshark-commits] master fad9b76: wslua field: fix Copy-paste error (CID 1158590 & 1158589) | 
Wireshark code review | 
 | 
| 17:13 | 
[Wireshark-commits] master f485b28: Test suite: Make sure we have a usable locale before we run iconv. | 
Wireshark code review | 
 | 
| 17:13 | 
[Wireshark-commits] master 02f41b1: GTPv2: fix Copy-paste error	(CID 1158587) | 
Wireshark code review | 
 | 
| 17:17 | 
[Wireshark-commits] master f42fe1a: Zbee ZDP: fix Copy-paste error	(CID 1158598) | 
Wireshark code review | 
 | 
| 18:04 | 
[Wireshark-commits] master ce9ca9d: rtse.cnf: fix Nesting level does not match indendation (CID 1159214) | 
Wireshark code review | 
 | 
| 19:34 | 
[Wireshark-commits] master cb7c949: Move some routines into	ws_version_info.c. | 
Wireshark code review | 
 | 
| 19:46 | 
[Wireshark-commits] master 35cf7c6: Distinguish between IA-32 and	non-x86. | 
Wireshark code review | 
 | 
| 19:52 | 
[Wireshark-commits] master d5d2c0e: ws_cpuid() returns a success/failure indication; make it gboolean. | 
Wireshark code review | 
 | 
| 20:10 | 
[Wireshark-commits] master c15b749: Qt: fix 'Limit to display filter' functionality in Conversations/Endpoints windows | 
Wireshark code review | 
 | 
| 20:25 | 
[Wireshark-commits] buildbot failure in Wireshark (development) on	Ubuntu 14.04 x64 | 
buildbot-no-reply | 
 | 
| 21:26 | 
[Wireshark-commits] master 93efc20: "#else", not "#elif", for the last part of a chain of conditionals. | 
Wireshark code review | 
 | 
| 21:43 | 
[Wireshark-commits] master 23b1127: Swallow get_glib_version_info() into get_compiled_version_info(). | 
Wireshark code review | 
 | 
| 22:47 | 
[Wireshark-commits] master 0e57ff2: We no longer do anything signal-related, so don't include <signal.h>. | 
Wireshark code review | 
 | 
| 22:48 | 
[Wireshark-commits] master 91e4330: Qt: Convert more dialog titles. | 
Wireshark code review | 
 | 
| 22:54 | 
[Wireshark-commits] master 1bc2565: Don't include signal.h unless	we need it. | 
Wireshark code review | 
 | 
| 23:33 | 
[Wireshark-commits] master 9a7d455: Use setlocale() to get the	current locale. | 
Wireshark code review | 
 |