Wireshark-commits: [Wireshark-commits] master 4d55e1f: Presumably the intent is to dump *non*-dummy
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 23 Nov 2014 20:53:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d55e1f455bc2c087b74d237a1da7914c2cfb915
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4d55e1f by Guy Harris (guy@xxxxxxxxxxxx):

    Presumably the intent is to dump *non*-dummy entries.
    
    I.e., presumably the intent is to dump *resolved* hosts, rather than
    *unresolved* hosts where there's no known host name and the name field
    is a string form of the address (the premise being that looking the
    address up in the hash table repeatedly, and using the already-generated
    string, will be faster than generating the string repeatedly).
    
    Change-Id: Iad1beb1d5f9cd9ed92bad5386111cb659614ee4d
    Reviewed-on: https://code.wireshark.org/review/5455
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  da5487f   Newlines at the ends of lines, please.
    adds  4d55e1f   Presumably the intent is to dump *non*-dummy entries.


Summary of changes:
 ui/cli/tap-hosts.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)