Wireshark-commits: [Wireshark-commits] master c61a037: Add version check in Geneve dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Nov 2014 13:48:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c61a037541e54bccdf5dfd5b2262b49ca820c5d7
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c61a037 by Jesse Gross (jesse@xxxxxxxxxx):

    Add version check in Geneve dissector.
    
    We should warn when decoding Geneve packets with an unknown
    version number.
    
    Change-Id: Id40b756c3bb0320b69fbd8ee98830a2b05834a48
    Reviewed-on: https://code.wireshark.org/review/5420
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  01f9706   Add the required c flags for some test executables
    adds  c61a037   Add version check in Geneve dissector.


Summary of changes:
 AUTHORS                         |    4 ++++
 epan/dissectors/packet-geneve.c |   48 +++++++++++++++++++++++++--------------
 2 files changed, 35 insertions(+), 17 deletions(-)