Wireshark-commits: [Wireshark-commits] master 219cf30: Fix SMPP timestamp decoding when the current
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Nov 2014 03:33:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=219cf304c1a028f4010ba8868d6bd8f6ae70541d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

219cf30 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Fix SMPP timestamp decoding when the current date/time's offset to UTC is
    different from the timestamp's offset to UTC.
    
    The fix for bug 6712 ignored the fact that daylight savings will affect the
    offset from UTC--and whether daylight savings is in effect today might be
    different than whether it was in effect in the timestamp we're decoding.
    
    Bug: 10672
    Change-Id: Ie513c361cff41007f2328cd9ca9ca4800ffef500
    Reviewed-on: https://code.wireshark.org/review/5245
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  cfd71d7   Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up on the OSX 10.5 buildbot.
    adds  219cf30   Fix SMPP timestamp decoding when the current date/time's offset to UTC is different from the timestamp's offset to UTC.


Summary of changes:
 epan/dissectors/packet-smpp.c |   35 ++++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 17 deletions(-)