Wireshark-commits: [Wireshark-commits] master fea733e: Add logic to determine if a "tvb get" call i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 30 Oct 2014 15:20:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fea733e82b290882b592adfef4b8ae621245f5cd
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fea733e by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add logic to determine if a "tvb get" call is used as a parameter to a proto_tree_add_text call. convert_proto_tree_add_text.pl has an easier time determining hf_ field values with a "tvb get" call present, so it's more likely those dissectors will be picked first in eliminating their proto_tree_add_text calls.
    
    Change-Id: I3dd57a73c8e60d8075a6bb987efd52b96b38445c
    Reviewed-on: https://code.wireshark.org/review/4997
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  f8c7a5b   Add an RFC reference and fix deprecated API.
    adds  fea733e   Add logic to determine if a "tvb get" call is used as a parameter to a proto_tree_add_text call. convert_proto_tree_add_text.pl has an easier time determining hf_ field values with a "tvb get" call present, so it's more likely those dissectors will be picked first in eliminating their proto_tree_add_text calls.


Summary of changes:
 tools/convert_proto_tree_add_text.pl |   25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)