Wireshark-commits: [Wireshark-commits] master 4acf495: Rename the strnatcmp.c routines and make the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 Oct 2014 17:54:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4acf4955f54c1fba30fdf2dc0dd4e11f6a3595b5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4acf495 by Guy Harris (guy@xxxxxxxxxxxx):

    Rename the strnatcmp.c routines and make them use the g_ascii_XXX() routines.
    
    Rename strnatcmp()/strnatcasecmp() to ws_ascii_XXX(), and make them use
    the g_ascii_XXX() routines rather than ctype.h routines, to eliminate
    locale-dependent behavior.
    
    (If you want locale-dependent "natural order" sorting, you probably want
    "dictionary order" sorting, which is more complicated than just natural
    order sorting.)
    
    Change-Id: I837f2776b2a909b547dc9a6072e497911b5380e5
    Reviewed-on: https://code.wireshark.org/review/4985
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d2f4b6f   Replace isalpha() with g_ascii_isprint().
    adds  4acf495   Rename the strnatcmp.c routines and make them use the g_ascii_XXX() routines.


Summary of changes:
 editcap.c          |    2 +-
 mergecap.c         |    4 ++--
 wsutil/strnatcmp.c |   19 +++++++++++++------
 wsutil/strnatcmp.h |    4 ++--
 4 files changed, 18 insertions(+), 11 deletions(-)