Wireshark · Wireshark-commits: [Wireshark-commits] master ceff4ed: Qt: Refactor ByteViewText.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ceff4edbf04d5725542208a533cc61ffdf7854b2
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ceff4ed by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Refactor ByteViewText.
    
    Instead of subclassing QTextEdit and filling it with the entire contents
    of our tvbuff, subclass QAbstractScrollArea and draw text by hand only
    when needed. The new code should be *much* faster.
    
    Some code based on QHexView by Even Teran
    (https://code.google.com/p/qhexview/).
    
    To do:
    - Finish the bit view implementation.
    
    Change-Id: Ie44de6870d80711cd44324521a17ab76bcefe5e5
    Reviewed-on: https://code.wireshark.org/review/4922
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  001dbaf   ESP: honor enable_null_encryption_decode_heuristic preference when the ESP packet does not match any known SA
    adds  ceff4ed   Qt: Refactor ByteViewText.


Summary of changes:
 docbook/release-notes.asciidoc |   10 +
 ui/qt/byte_view_tab.cpp        |    2 -
 ui/qt/byte_view_text.cpp       |  548 ++++++++++++++++++++--------------------
 ui/qt/byte_view_text.h         |   63 +++--
 ui/qt/proto_tree.cpp           |    3 +-
 5 files changed, 331 insertions(+), 295 deletions(-)