Wireshark-commits: [Wireshark-commits] master 97a920c: Don't free global_capture_opts.ifaces_err_in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 23 Oct 2014 10:28:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97a920cb21c0617f78a03c33510594e9904fd052
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

97a920c by Guy Harris (guy@xxxxxxxxxxxx):

    Don't free global_capture_opts.ifaces_err_info.
    
    Leave it around in case InterfaceTree::display() gets invoked without an
    intervening call to scan_local_interfaces() (that would cause a
    double-free) or in case scan_local_interfaces() gets called afterwards
    (as it frees global_capture_opts.ifaces_err_info before setting it
    again, so there's no leak there, but there would be a double-free).
    
    This should prevent at least one crash I've seen.
    
    Change-Id: Iedd3959b420c09971557c473cc87aefd4454078c
    Reviewed-on: https://code.wireshark.org/review/4917
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a0d5ef8   Lua: Added support for FT_EUI64.
    adds  97a920c   Don't free global_capture_opts.ifaces_err_info.


Summary of changes:
 ui/qt/interface_tree.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)