Wireshark-commits: [Wireshark-commits] master 7522497: With CMake, define WANT_PACKET_EDITOR in con
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 21 Oct 2014 05:29:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7522497b67ca259e08c9d2c990437c0c0afb9955
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7522497 by Guy Harris (guy@xxxxxxxxxxxx):

    With CMake, define WANT_PACKET_EDITOR in config.h.
    
    Just as we do with autotools and nmake, define it in config.h, so it's
    defined the same for every single file, rather than defining it in one
    particular directory's Makefiles, so that it's defined for some code but
    not all.
    
    Change-Id: Ic41cd10f2b502e0be76c134cbeaad94dff7623f8
    Reviewed-on: https://code.wireshark.org/review/4891
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8dd032e   file.c isn't in a DLL, so what it exports shouldn't be WS_DLL_PUBLIC.
    adds  7522497   With CMake, define WANT_PACKET_EDITOR in config.h.


Summary of changes:
 cmakeconfig.h.in      |    3 +++
 ui/gtk/CMakeLists.txt |    6 ------
 2 files changed, 3 insertions(+), 6 deletions(-)